Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753242AbbKJOZz (ORCPT ); Tue, 10 Nov 2015 09:25:55 -0500 Received: from mail.savoirfairelinux.com ([208.88.110.44]:34762 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284AbbKJOZy (ORCPT ); Tue, 10 Nov 2015 09:25:54 -0500 Date: Tue, 10 Nov 2015 09:25:51 -0500 From: Vivien Didelot To: Neil Armstrong Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Florian Fainelli , Andrew Lunn , Guenter Roeck Subject: Re: [PATCH 5/6] net: dsa: mv88e6060: add register defines header file Message-ID: <20151110142550.GB29568@ketchup.mtl.sfl> References: <5641F04A.9060303@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5641F04A.9060303@baylibre.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1358 Lines: 38 Hi Neil, On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote: > To align with the mv88e6xxx code, add a similar header file > with all the register defines. > The file is based on the mv88e6xxx header for coherency. > > Signed-off-by: Neil Armstrong In the RFC patchset, Andrew mentioned that there is not that much things in common with mv88e6xxx, so I don't really see a value to add a separate header file. Would that make sense to you guys to add the defines directly in mv88e6060.c and squash that in the last patch? > --- > drivers/net/dsa/mv88e6060.h | 108 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 108 insertions(+) > create mode 100644 drivers/net/dsa/mv88e6060.h > > diff --git a/drivers/net/dsa/mv88e6060.h b/drivers/net/dsa/mv88e6060.h > new file mode 100644 > index 0000000..adbc894 > --- /dev/null > +++ b/drivers/net/dsa/mv88e6060.h > @@ -0,0 +1,108 @@ > +/* > + * net/dsa/mv88e6060.h - Marvell 88e6060 switch chip support > + * Copyright (c) 2008 Marvell Semiconductor Also I don't think the copyright notice is correct here. Thanks, -v -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/