Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbbKJOlx (ORCPT ); Tue, 10 Nov 2015 09:41:53 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:35140 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751601AbbKJOlv (ORCPT ); Tue, 10 Nov 2015 09:41:51 -0500 MIME-Version: 1.0 X-Originating-IP: [217.173.34.11] In-Reply-To: <1444656824-26292-1-git-send-email-klamm@yandex-team.ru> References: <5612C357.1050000@parallels.com> <1444656824-26292-1-git-send-email-klamm@yandex-team.ru> Date: Tue, 10 Nov 2015 15:41:50 +0100 Message-ID: Subject: Re: [PATCH v2] fuse: break infinite loop in fuse_fill_write_pages() From: Miklos Szeredi To: Roman Gushchin Cc: Kernel Mailing List , Al Viro , fuse-devel , Andrew Morton , Maxim Patlasov , Konstantin Khlebnikov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 19 On Mon, Oct 12, 2015 at 3:33 PM, Roman Gushchin wrote: > I got a report about unkillable task eating CPU. Further > investigation shows, that the problem is in the fuse_fill_write_pages() > function. If iov's first segment has zero length, we get an infinite > loop, because we never reach iov_iter_advance() call. > > Fix this by calling iov_iter_advance() before repeating an attempt to > copy data from userspace. Thanks, queued in git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-next Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/