Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753567AbbKJOyf (ORCPT ); Tue, 10 Nov 2015 09:54:35 -0500 Received: from mail-vk0-f48.google.com ([209.85.213.48]:35731 "EHLO mail-vk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753093AbbKJOyd (ORCPT ); Tue, 10 Nov 2015 09:54:33 -0500 MIME-Version: 1.0 In-Reply-To: <20151110145146.GA1551@rob-hp-laptop> References: <1446127303-5082-1-git-send-email-peter.maydell@linaro.org> <20151110145146.GA1551@rob-hp-laptop> From: Peter Maydell Date: Tue, 10 Nov 2015 14:54:13 +0000 Message-ID: Subject: Re: [PATCH] Documentation: dt: Add bindings for Secure-only devices To: Rob Herring Cc: "devicetree@vger.kernel.org" , Mark Rutland , Pawel Moll , Ian Campbell , "linux-kernel@vger.kernel.org" , Roy Franz , "linux-arm-kernel@lists.infradead.org" , Kumar Gala , Jens Wiklander , Christoffer Dall , Grant Likely Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 893 Lines: 23 On 10 November 2015 at 14:51, Rob Herring wrote: > On Fri, Oct 30, 2015 at 08:07:34PM +0000, Peter Maydell wrote: >> + status = "okay"; secure-status = "okay"; // ditto >> + secure-status = "okay"; // ditto >> + // neither explicitly defined: ditto >> >> (Do you want the full set of 9 options you get from multiplying >> out "okay" vs "disabled" vs not-set for each property?) > > Better to err on completeness. The inheritance is easily missed. > > Also, one nit. Use C style comments so when people copy-n-paste this it > is the correct style. OK; I'll send out a v2 with these fixes. thanks -- PMM -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/