Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753871AbbKJPde (ORCPT ); Tue, 10 Nov 2015 10:33:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36961 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753778AbbKJPdc (ORCPT ); Tue, 10 Nov 2015 10:33:32 -0500 From: Jeff Moyer To: Jerry Hoemann Cc: ross.zwisler@linux.intel.com, rjw@rjwysocki.net, lenb@kernel.org, dan.j.williams@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org Subject: Re: [PATCH 0/4] nvdimm: Add an IOCTL pass thru for DSM calls References: X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 10 Nov 2015 10:33:29 -0500 In-Reply-To: (Jerry Hoemann's message of "Fri, 6 Nov 2015 15:27:27 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1281 Lines: 37 Jerry Hoemann writes: > The NVDIMM code in the kernel supports an IOCTL interface to user > space based upon the Intel Example DSM: > > http://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf > > This interface cannot be used by other NVDIMM DSMs that support > incompatible functions. > > This patch set adds a generic "passthru" IOCTL interface which > is not tied to a particular DSM. > > A new IOCTL type "P" is added for the pass thru call. > > The new data structure ndn_pkg serves as a wrapper for the passthru > calls. This wrapper supplies the data that the kernel needs to > make the _DSM call. What does 'ndn' stand for? If it stands for NVDIMM-N, then I think that's too narrow a scope. Anyway, it helps readability if you call out what abbreviations mean, especially when it's non-obvious. > Jerry Hoemann (4): > nvdimm: Add wrapper for IOCTL pass thru. > nvdimm: Add IOCTL pass thru > nvdimm: Add IOCTL pass thru You should really give each patch a different subject. Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/