Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754075AbbKJP5F (ORCPT ); Tue, 10 Nov 2015 10:57:05 -0500 Received: from www.linutronix.de ([62.245.132.108]:44966 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752769AbbKJP5D (ORCPT ); Tue, 10 Nov 2015 10:57:03 -0500 Date: Tue, 10 Nov 2015 10:55:49 -0500 (EST) From: Thomas Gleixner To: John Stultz cc: Stefano Stabellini , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , xen-devel@lists.xensource.com, Ian.Campbell@citrix.com, Peter Zijlstra , lkml , Ingo Molnar Subject: Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 In-Reply-To: Message-ID: References: <1447156675-7418-1-git-send-email-stefano.stabellini@eu.citrix.com> <4372800.FdTygmcuyo@wuerfel> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1255 Lines: 30 On Tue, 10 Nov 2015, John Stultz wrote: > I'm sort of objecting to a different issue, where the > __current_kernel_time() implementation probably shouldn't be grabbing > the tk_core.timekeeper directly, and instead should take a passed > pointer to a timekeeper. The vdso/pv_clock usage should have a > timekeeper passed to them that they could use. That usage of __current_kernel_time() in that xen notifier is silly to begin with. The notifier gets already called with a pointer to the time keeper. That xen implementation just does not use it. We extract exactly that information in the vdso updates without calling back into the core code. So for solving that xen thing we do not need a 64 bit variant of __current_kernel_time() at all. The notifier has the pointer to the timekeeper and can just grab data from there. > There's one useage in kdb thats maybe problematic, so maybe this will > need a deeper cleanup. That one is silly as well. It only wants to know the seconds portion. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/