Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754157AbbKJQvL (ORCPT ); Tue, 10 Nov 2015 11:51:11 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33859 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753479AbbKJQvJ (ORCPT ); Tue, 10 Nov 2015 11:51:09 -0500 Message-ID: <5642207A.9070406@linaro.org> Date: Tue, 10 Nov 2015 08:51:06 -0800 From: "Shi, Yang" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Catalin Marinas CC: will.deacon@arm.com, mark.rutland@arm.com, linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it References: <1447092595-12644-1-git-send-email-yang.shi@linaro.org> <20151110103752.GH21606@e104818-lin.cambridge.arm.com> In-Reply-To: <20151110103752.GH21606@e104818-lin.cambridge.arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 33 On 11/10/2015 2:37 AM, Catalin Marinas wrote: > On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: >> FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine >> it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory >> is never used. > > That's not true since the arm64 definition seems to take precedence. > >> This adds a dependency on DEBUG_KERNEL for building with frame pointers. > > It doesn't because arm64 selects ARCH_WANT_FRAME_POINTERS. Thanks for pointing it out. I misread the order of precedence, still think of C syntax at the first place. Yang > >> ARM64 depends on frame pointer to get correct stack backtrace and need >> FRAME_POINTER kconfig option enabled all the time. >> However, currect implementation makes it could be disabled, so force it >> to be selected by ARM64. >> >> Signed-off-by: Yang Shi > > Patch applied but I changed the commit log slightly. Thanks. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/