Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752594AbbKJRse (ORCPT ); Tue, 10 Nov 2015 12:48:34 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:37992 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751998AbbKJRsd (ORCPT ); Tue, 10 Nov 2015 12:48:33 -0500 MIME-Version: 1.0 In-Reply-To: References: <1447061851-19932-1-git-send-email-geert@linux-m68k.org> Date: Tue, 10 Nov 2015 09:48:32 -0800 Message-ID: Subject: Re: [PATCH] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA From: Moritz Fischer To: atull Cc: Geert Uytterhoeven , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1505 Lines: 55 Hi Alan, Geert On Tue, Nov 10, 2015 at 8:28 AM, atull wrote: > On Mon, 9 Nov 2015, Geert Uytterhoeven wrote: > > +Moritz > >> If NO_DMA=y: >> >> ERROR: "dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined! >> ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined! >> >> Add a dependency on HAS_DMA to fix this. >> >> Signed-off-by: Geert Uytterhoeven >> --- >> drivers/fpga/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig >> index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644 >> --- a/drivers/fpga/Kconfig >> +++ b/drivers/fpga/Kconfig >> @@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA >> >> config FPGA_MGR_ZYNQ_FPGA >> tristate "Xilinx Zynq FPGA" >> + depends on HAS_DMA >> help >> FPGA manager driver support for Xilinx Zynq FPGAs. >> >> -- >> 1.9.1 >> >> Good catch! Reviewed-by: Moritz Fischer Alan, if you don't mind I'll send you (or gregkh?) a patch with adding me as (co) maintainer, or Reviewer to the MAINTAINERS file so you don't have to forward manually next time any more ;-) I doubt Geert's patch caught the last issue in zynq-fpga ;-) Cheers, Moritz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/