Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754724AbbKJSFK (ORCPT ); Tue, 10 Nov 2015 13:05:10 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:34385 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754662AbbKJSFG (ORCPT ); Tue, 10 Nov 2015 13:05:06 -0500 MIME-Version: 1.0 In-Reply-To: References: <5411049831df211c8280e3239aaf344af033fa25.1446684001.git.jerry.hoemann@hpe.com> Date: Tue, 10 Nov 2015 10:05:04 -0800 Message-ID: Subject: Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. From: Dan Williams To: Jeff Moyer Cc: Jerry Hoemann , Ross Zwisler , "Rafael J. Wysocki" , Len Brown , Linux ACPI , "linux-kernel@vger.kernel.org" , linux-nvdimm Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 909 Lines: 22 On Tue, Nov 10, 2015 at 9:51 AM, Jeff Moyer wrote: > Jerry Hoemann writes: > >> Add IOCTL type 'P' to denote NVDIMM_TYPE_PASSTHRU. > > Can't you just make passthrough a separate command? If you actually add > the ioctl definition for passthrough (which you didn't do for some > reason?), it looks odd: > > #define ND_IOCTL_PASSTHRU _IOWR(NVDIMM_TYPE_PASSTHRU,, ND_CMD_PASSTHRU, \ > struct ndn_package) > > Care to comment on why you chose a different type instead of specifying > a new command? +1 for making this just a new command number without a new top-level number space. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/