Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754865AbbKJSFZ (ORCPT ); Tue, 10 Nov 2015 13:05:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38917 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754716AbbKJSFW (ORCPT ); Tue, 10 Nov 2015 13:05:22 -0500 From: Jeff Moyer To: Jerry Hoemann Cc: ross.zwisler@linux.intel.com, rjw@rjwysocki.net, lenb@kernel.org, dan.j.williams@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org Subject: Re: [PATCH 2/4] nvdimm: Add IOCTL pass thru References: <4f81a8b6fa24723c808c72888290e2368fcdbca0.1446684001.git.jerry.hoemann@hpe.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 10 Nov 2015 13:05:20 -0500 In-Reply-To: <4f81a8b6fa24723c808c72888290e2368fcdbca0.1446684001.git.jerry.hoemann@hpe.com> (Jerry Hoemann's message of "Fri, 6 Nov 2015 15:27:29 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 999 Lines: 29 Jerry Hoemann writes: > Add internal data structure for ndctl_passthru call. > > Signed-off-by: Jerry Hoemann > --- > include/linux/libnvdimm.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/libnvdimm.h b/include/linux/libnvdimm.h > index 3f021dc..01117e1 100644 > --- a/include/linux/libnvdimm.h > +++ b/include/linux/libnvdimm.h > @@ -72,6 +72,7 @@ struct nvdimm_bus_descriptor { > unsigned long dsm_mask; > char *provider_name; > ndctl_fn ndctl; > + ndctl_fn ndctl_passthru; I don't think this is necessary. Vector off inside of __nd_ioctl. That especially makes sense if you do switch to passthrough as a command instead of a type, but it can work either way. -Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/