Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751972AbbKJVi3 (ORCPT ); Tue, 10 Nov 2015 16:38:29 -0500 Received: from mail-ig0-f171.google.com ([209.85.213.171]:35172 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751322AbbKJVi1 (ORCPT ); Tue, 10 Nov 2015 16:38:27 -0500 MIME-Version: 1.0 In-Reply-To: References: <1446912609-2573-1-git-send-email-simon@mungewell.org> <1446912609-2573-6-git-send-email-simon@mungewell.org> Date: Tue, 10 Nov 2015 22:38:27 +0100 Message-ID: Subject: Re: [PATCH 5/6] HID: Add vendor specific usage pages for Logitech G920 From: Elias Vanderstuyft To: Benjamin Tissoires Cc: Simon Wood , linux-input , "linux-kernel@vger.kernel.org" , Jiri Kosina , Edwin , =?UTF-8?B?TWljaGFsIE1hbMO9?= , Benjamin Tissoires Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1534 Lines: 39 On Mon, Nov 9, 2015 at 9:20 AM, Benjamin Tissoires wrote: > On Sat, Nov 7, 2015 at 5:10 PM, Simon Wood wrote: >> The Logitech G920 uses a couple of vendor specific usage pages, >> which results in incorrect number of axis/buttons being detected. >> >> This patch adds these pages to the 'ignore' list. >> >> Reported-by: Elias Vanderstuyft >> Signed-off-by: Simon Wood >> --- >> drivers/hid/hid-input.c | 2 +- >> include/linux/hid.h | 2 ++ >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c >> index 53aeaf6..c120be5 100644 >> --- a/drivers/hid/hid-input.c >> +++ b/drivers/hid/hid-input.c >> @@ -959,7 +959,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel >> set_bit(EV_REP, input->evbit); >> goto ignore; >> >> - case HID_UP_LOGIVENDOR: >> + case HID_UP_LOGIVENDOR: case HID_UP_LOGIVENDOR2: case HID_UP_LOGIVENDOR3: > > One line per case, please. This is my fault, I followed the convention used some lines above: "case HID_GD_SLIDER: case HID_GD_DIAL: case HID_GD_WHEEL:" but we expected this would get comments ;-) Cheers, Elias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/