Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752188AbbKJWFg (ORCPT ); Tue, 10 Nov 2015 17:05:36 -0500 Received: from mga14.intel.com ([192.55.52.115]:23554 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035AbbKJWFf (ORCPT ); Tue, 10 Nov 2015 17:05:35 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,272,1444719600"; d="scan'208";a="847938277" Date: Tue, 10 Nov 2015 14:05:28 -0800 From: "Luck, Tony" To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 1/3] x86, ras: Add new infrastructure for machine check fixup tables Message-ID: <20151110220527.GB28172@agluck-desk.sc.intel.com> References: <5bf6f812a7dd2b619487c57987e29b3884c6c4ec.1447093568.git.tony.luck@intel.com> <20151110112116.GC19187@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151110112116.GC19187@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 30 On Tue, Nov 10, 2015 at 12:21:16PM +0100, Borislav Petkov wrote: > > +# define _ASM_MCEXTABLE(from, to) \ > > Maybe add an intermediary macro which abstracts the table name: > > #define __ASM_EXTABLE(from, to, table) > ... > > and then do > > #define _ASM_EXTABLE(from, to) __ASM_EXTABLE(from, to, "__ex_table") > #define _ASM_MCEXTABLE(from, to) __ASM_EXTABLE(from, to, "__mcex_table") That looks a bit nicer. > > Yeah, all that duplication might raise some brows but I'd guess > special-handling MCA in the normal exception paths might make the code > a bit too ugly... The 0-day robot berated me for bloating the i386-tinyconfig by 88 bytes. I guess I can put the new functions inside #ifdef CONFIG_MEMORY_FAILURE to save them from that. Enterprise kernels that turn this option on can probably live with 88 bytes. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/