Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752008AbbKJWN5 (ORCPT ); Tue, 10 Nov 2015 17:13:57 -0500 Received: from g1t5424.austin.hp.com ([15.216.225.54]:38204 "EHLO g1t5424.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285AbbKJWN4 (ORCPT ); Tue, 10 Nov 2015 17:13:56 -0500 X-Greylist: delayed 2910 seconds by postgrey-1.27 at vger.kernel.org; Tue, 10 Nov 2015 17:13:55 EST Date: Tue, 10 Nov 2015 15:13:52 -0700 From: Jerry Hoemann To: Jeff Moyer Cc: ross.zwisler@linux.intel.com, rjw@rjwysocki.net, lenb@kernel.org, dan.j.williams@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org Subject: Re: [PATCH 2/4] nvdimm: Add IOCTL pass thru Message-ID: <20151110221352.GE47666@tevye.fc.hp.com> Reply-To: Jerry.Hoemann@hpe.com References: <4f81a8b6fa24723c808c72888290e2368fcdbca0.1446684001.git.jerry.hoemann@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1981 Lines: 49 On Tue, Nov 10, 2015 at 01:05:20PM -0500, Jeff Moyer wrote: > Jerry Hoemann writes: > > > Add internal data structure for ndctl_passthru call. > > > > Signed-off-by: Jerry Hoemann > > --- > > include/linux/libnvdimm.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/libnvdimm.h b/include/linux/libnvdimm.h > > index 3f021dc..01117e1 100644 > > --- a/include/linux/libnvdimm.h > > +++ b/include/linux/libnvdimm.h > > @@ -72,6 +72,7 @@ struct nvdimm_bus_descriptor { > > unsigned long dsm_mask; > > char *provider_name; > > ndctl_fn ndctl; > > + ndctl_fn ndctl_passthru; > > I don't think this is necessary. Vector off inside of __nd_ioctl. That > especially makes sense if you do switch to passthrough as a command > instead of a type, but it can work either way. > In an earlier version, I added a "type" argument to ndctl_fn and switched internally based upon that. I just came to the conclusion that I'd rather have two separate acpi_nfit_ctl functions than one trying to do both sets of argument marshaling. This is quite different both internally and to the caller. So, I thought it would be less confusing to the next engineer, and that this was a good logical separation point. -- ----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett-Packard Enterprise 3404 E Harmony Rd. MS 36 phone: (970) 898-1022 Ft. Collins, CO 80528 FAX: (970) 898-0707 email: jerry.hoemann@hpe.com ----------------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/