Message-ID: <56428C1B.5000405@rock-chips.com>
Date: Wed, 11 Nov 2015 08:30:19 +0800
From: Mark yao <mark.yao@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Heiko Stuebner <heiko@sntech.de>
CC: David Airlie <airlied@linux.ie>, Russell King <linux@arm.linux.org.uk>,
        dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
        Dominik Behr <dbehr@chromium.org>
Subject: Re: [PATCH] drm/rockchip: vop: fix window origin calculation
References: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> <2130118.giXtpUm1Fo@phil>
In-Reply-To: <2130118.giXtpUm1Fo@phil>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1948
Lines: 60

On 2015年11月10日 22:57, Heiko Stuebner wrote:
> Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao:
>> From: Dominik Behr <dbehr@chromium.org>
>>
>> VOP_WINx_DSP_ST does not require subtracting 1 from the values written to
>> it. It actually causes the screen to be shifted by one pixel.
>>
>> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> One thing I noticed, the original patch [0] had a Signed-off from
> Dominik already and you should keep that as he is the author, and then
> add your Signed-off below that, as you are the submitter,
>
> So it would look like:
>
> Signed-off-by: Dominik Behr <dbehr@chromium.org>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
>
>
> That may not need a repost, but should probably be corrected when applying
> the patch.
>
> Heiko
>
> [0] https://chromium-review.googlesource.com/#/c/233251/
>
Got it, thanks.
>> ---
>>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
>> index 48719df..4730ae4 100644
>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
>> @@ -959,8 +959,8 @@ static int vop_update_plane_event(struct drm_plane *plane,
>>   	val = (dest.y2 - dest.y1 - 1) << 16;
>>   	val |= (dest.x2 - dest.x1 - 1) & 0xffff;
>>   	VOP_WIN_SET(vop, win, dsp_info, val);
>> -	val = (dsp_sty - 1) << 16;
>> -	val |= (dsp_stx - 1) & 0xffff;
>> +	val = dsp_sty << 16;
>> +	val |= dsp_stx & 0xffff;
>>   	VOP_WIN_SET(vop, win, dsp_st, val);
>>   	VOP_WIN_SET(vop, win, rb_swap, rb_swap);
>>   
>>
>
>
>


-- 
Ｍark Yao


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/