Message-ID: <876119fejk.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
CC: Ulf Hansson <ulf.hansson@linaro.org>, Zhang Rui <rui.zhang@intel.com>,
        Eduardo Valentin <edubezval@gmail.com>,
        Linux-SH <linux-sh@vger.kernel.org>,
        Linux-Kernel <linux-kernel@vger.kernel.org>,
        Linux PM list <linux-pm@vger.kernel.org>,
        Cao Minh Hiep <cm-hiep@jinso.co.jp>,
        =?ISO-2022-JP?B?RHVuZxskQiEnP00lPRsoQg==?= <nv-dung@jinso.co.jp>
Subject: Re: [PATCH 2/2] thermal: rcar_thermal: use pm_runtime_put_sync()
In-Reply-To: <CAMuHMdWSMsVZYF2jswCoRB217n_3OR8uikNtBYOfQHkQs3oWSA@mail.gmail.com>
References: <87h9kulkfg.wl%kuninori.morimoto.gx@renesas.com>
	<87fv0elibh.wl%kuninori.morimoto.gx@renesas.com>
	<87d1vili9c.wl%kuninori.morimoto.gx@renesas.com>
	<CAMuHMdWSMsVZYF2jswCoRB217n_3OR8uikNtBYOfQHkQs3oWSA@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
Date: Wed, 11 Nov 2015 02:41:38 +0000
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2015 02:41:38.4382 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HKXPR06MB1016
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 900
Lines: 28


Hi Geert

> > -       pm_runtime_put(dev);
> > +       pm_runtime_put_sync(dev);
> >         pm_runtime_disable(dev);
> >
> >         return 0;
> 
> While I can confirm this fixes the issue, I think this is a bug in the PM
> core, and thus your patch is merely a workaround.
> 
> Morimoto-san: I assume this is a recent regression. Have you tried to bisect?

I thought that this is driver side issue, but I noticed that it was working before.
I tried bisect, and found that this patch breaks bind/unbind

	cbc41d0a761bffb3166a413a3c77100a737c0cd7
	("drivers: sh: Disable PM runtime for multi-platform ARM with genpd")

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/