Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165AbbKKDaP (ORCPT ); Tue, 10 Nov 2015 22:30:15 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:46088 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751612AbbKKDaN (ORCPT ); Tue, 10 Nov 2015 22:30:13 -0500 Date: Wed, 11 Nov 2015 03:30:07 +0000 From: Al Viro To: Linus Torvalds Cc: Sasha Levin , Andrey Ryabinin , Matthew Wilcox , Chuck Ebbert , linux-fsdevel , LKML , Jens Axboe , Dan Williams Subject: Re: fs: out of bounds on stack in iov_iter_advance Message-ID: <20151111033007.GI22011@ZenIV.linux.org.uk> References: <20150815161338.4ea210ff@as> <55D1A6D4.3080605@gmail.com> <20150819054650.GD18890@ZenIV.linux.org.uk> <55FB75D0.7060403@oracle.com> <560C5469.5010704@oracle.com> <20151106013402.GT22011@ZenIV.linux.org.uk> <20151106021858.GU22011@ZenIV.linux.org.uk> <20151111025647.GG22011@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151111025647.GG22011@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3423 Lines: 68 On Wed, Nov 11, 2015 at 02:56:47AM +0000, Al Viro wrote: > s/developed/rebased/, actually, but... point taken. Mea culpa, and what > to do with those patches is for you to decide; some of those are simply > -stable fodder and probably ought to go one-by-one at any point you would > consider convenient, some are of the "remove stale comment" variety (obviously > can sit around until the next cycle, or go in one-by-one at any point - the > things like > - > - /* WARNING: probably going away soon, do not use! */ > in inode_operations; the comment used to be about the method removed last > cycle and should've been gone with it; etc.) FWIW, here's what's in there: dax_io fix Jens has just taken it fs: fix inode.c kernel-doc warning fs: fix writeback.c kernel-doc warnings trivial comment patches overlayfs: move super block magic number to magic.h got picked into overlayfs tree yesterday debugfs: fix refcount imbalance in start_creating old fix, -stable fodder (had been first posted in October, IIRC) vfs: Check attribute names in posix acl xattr handers vfs: Fix the posix_acl_xattr_list return value ubifs: Remove unused security xattr handler hfsplus: Remove unused xattr handler list operations jffs2: Add missing capability check for listing trusted xattrs xattr handlers: Pass handler to operations instead of flags 9p: xattr simplifications squashfs: xattr simplifications f2fs: xattr simplifications xattr series; the first two are arguably fixes, and whatever happens in this window, I'm taking the rest into -next for 4.5. Series makes sense and cleans the things nicely, IMO. FS-Cache: Increase reference of parent after registering, netfs success FS-Cache: Don't override netfs's primary_index if registering failed cachefiles: perform test on s_blocksize when opening cache file. FS-Cache: Handle a write to the page immediately beyond the EOF marker 1, 2 and 4 are simply -stable fodder, 3 is an obvious optimization. binfmt_elf: Don't clobber passed executable's file header binfmt_elf: Correct `arch_check_elf's description -stable fodder. fs/pipe.c: preserve alloc_file() error code fs/pipe.c: return error code rather than 0 in pipe_write() -stable fodder. vfs: remove unused wrapper block_page_mkwrite() vfs: remove stale comment in inode_operations dead code and stale comment removal. Can go at any point. fs: 9p: cache.h: Add #define of include guard trivial, can go at any point, or stay until the next cycle. richacl series probably misses the window - I'd really like to hear more detailed variant of Christoph's objections in any case. Again, my apologies to everyone involved - I'd fucked up, badly. The only question is how much PITA it will end up causing. I can put those into separate branches and/or mail directly; what ends up missing the window will go into vfs.git#for-next as soon as -rc1 is out there (with the possible exception of richacl stuff - I really want to hear from Christoph and in more details than "it's all been said some iterations ago"). Linus, what would be your preference wrt that stuff? Besides the "don't ever do that kind of shit again", that is - that much is obvious. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/