From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Jason Liu <r64343@freescale.com>, dmaengine@vger.kernel.org,
        vinod.koul@intel.com, dan.j.williams@intel.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] dmaengine: imx-sdma: remove __init annotation on sdma_event_remap
Date: Wed, 11 Nov 2015 11:01:33 +0100
Message-ID: <4267122.WHg3VAy8bL@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1447233649-21464-1-git-send-email-r64343@freescale.com>
References: <1447233649-21464-1-git-send-email-r64343@freescale.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1413
Lines: 34

On Wednesday 11 November 2015 17:20:49 Jason Liu wrote:
> The sdma_probe function will call sdma_event_remap, but sdma_event_remap
> marked with the __init annotation which make the kbuild complains as the
> following log:
> 
> WARNING: drivers/dma/built-in.o(.text+0x56fc): Section mismatch in reference
> from the function sdma_probe() to the function .init.text:sdma_event_remap()
> The function sdma_probe() references
> the function __init sdma_event_remap().
> This is often because sdma_probe lacks a __init
> annotation or the annotation of sdma_event_remap is wrong.
> 
> Remove the __init annotation on sdma_event_remap to kill this build warning
> 
> Signed-off-by: Jason Liu <r64343@freescale.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> 

Looks good. I wonder why I have not caught this with the randconfig builds yet.

Acked-by: Arnd Bergmann <arnd@arndb.de>

One hint for the future: in the patch description, write less about the
kbuild warning and more about the actual impact of the bug (calling a
discarded function if the device gets unbound and rebound later, or
if we get deferred probing).

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/