Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687AbbKKM4w (ORCPT ); Wed, 11 Nov 2015 07:56:52 -0500 Received: from mx2.suse.de ([195.135.220.15]:56415 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752219AbbKKM4v (ORCPT ); Wed, 11 Nov 2015 07:56:51 -0500 Message-ID: <56433B10.6080000@suse.de> Date: Wed, 11 Nov 2015 13:56:48 +0100 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Sreekanth Reddy , jejb@kernel.org CC: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, JBottomley@Parallels.com, Sathya.Prakash@avagotech.com, kashyap.desai@avagotech.com, linux-kernel@vger.kernel.org, hch@infradead.org, chaitra.basappa@avagotech.com, suganath-prabu.subramani@avagotech.com Subject: Re: [PATCH RESEND 06/25] mpt3sas: Define 'hba_mpi_version_belonged' IOC variable References: <1447243241-10912-1-git-send-email-Sreekanth.Reddy@avagotech.com> <1447243241-10912-7-git-send-email-Sreekanth.Reddy@avagotech.com> In-Reply-To: <1447243241-10912-7-git-send-email-Sreekanth.Reddy@avagotech.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1426 Lines: 39 On 11/11/2015 01:00 PM, Sreekanth Reddy wrote: > From: Sreekanth Reddy > > 1. Use 'hba_mpi_version_belonged' IOC varable to uniquely > identify each individual generation driver functionality at > runtime. > > 2. Declared global variable 'driver_name' and used > this variable while reserving PCI regions and while > allocating the IRQ's. > > Signed-off-by: Sreekanth Reddy > --- > drivers/scsi/mpt2sas/mpt2sas_module.c | 1 + > drivers/scsi/mpt3sas/mpt3sas_base.c | 8 +++---- > drivers/scsi/mpt3sas/mpt3sas_base.h | 3 +++ > drivers/scsi/mpt3sas/mpt3sas_ctl.c | 18 +++++++++++++--- > drivers/scsi/mpt3sas/mpt3sas_module.c | 1 + > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 39 ++++++++++++++++++++++++++++++++++- > 6 files changed, 62 insertions(+), 8 deletions(-) > I'd rather shorten that to 'hba_mpi_version'. Other than that it's okay. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/