Date: Wed, 11 Nov 2015 15:51:55 +0100
From: Mathieu OTHACEHE <m.othacehe@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v4] USB: serial: add Moxa UPORT 11x0 driver
Message-ID: <20151111145154.GB5501@gmail.com>
References: <1447234547-15192-1-git-send-email-m.othacehe@gmail.com>
 <20151111094004.GD28385@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151111094004.GD28385@localhost>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1935
Lines: 56

Hi Johan

Ok, I'll include a changelog in future patches. Here is the current changlog :

Changes in v2:
* Use generic implementation for read/write code
* Use TIOCSRS485/TIOCGRS485 instead of moxa specific ioctl
* Other problems pointed out by Johan review

Changes in v3:
* Drop unused defines
* Fix style problems
* Remove port identification code since this driver is for one-port devices only
* Fix debug messages
* Use a mutex to protect shadow_mc
* Use usb_serial_generic_open and close
* Other problems pointed out by Johan review

Changes in v4:
* mxu1_startup return -ENODEV on purpose if the firmware was downloaded.
It avoids port_probe to fail since the device is reset.

Thanks,
Mathieu

On Wed, Nov 11, 2015 at 10:40:04AM +0100, Johan Hovold wrote:
> On Wed, Nov 11, 2015 at 10:35:47AM +0100, Mathieu OTHACEHE wrote:
> > Add a driver which supports :
> > 
> > - UPort 1110  : 1 port RS-232 USB to Serial Hub.
> > - UPort 1130  : 1 port RS-422/485 USB to Serial Hub.
> > - UPort 1130I : 1 port RS-422/485 USB to Serial Hub with Isolation.
> > - UPort 1150  : 1 port RS-232/422/485 USB to Serial Hub.
> > - UPort 1150I : 1 port RS-232/422/485 USB to Serial Hub with Isolation.
> > 
> > This driver is based on GPL MOXA driver written by Hen Huang and available
> > on MOXA website. The original driver was based on io_ti serial driver.
> > 
> > Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>
> > ---
> 
> Thanks for the v4. It'll be a few days still before I have a chance to
> review it.
> 
> What changed since v3 (and v2)?
> 
> Please include a summary of the changes below the cutoff line (i.e.
> here) when you send a new revision of a patch.
> 
> Thanks,
> Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/