Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752436AbbKKPKD (ORCPT ); Wed, 11 Nov 2015 10:10:03 -0500 Received: from netrider.rowland.org ([192.131.102.5]:58428 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750938AbbKKPKB (ORCPT ); Wed, 11 Nov 2015 10:10:01 -0500 Date: Wed, 11 Nov 2015 10:10:00 -0500 (EST) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Lu Baolu cc: Mathias Nyman , Greg Kroah-Hartman , , Subject: Re: [PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device In-Reply-To: <1447229006-15011-4-git-send-email-baolu.lu@linux.intel.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1163 Lines: 34 On Wed, 11 Nov 2015, Lu Baolu wrote: > Commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical sections.") > adds usb3_lpm_enabled member to struct usb_device. There is no reference > to this member now. Hence, it could be removed. > > Signed-off-by: Lu Baolu > --- > include/linux/usb.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/usb.h b/include/linux/usb.h > index 211664f..036e4a5 100644 > --- a/include/linux/usb.h > +++ b/include/linux/usb.h > @@ -583,7 +583,6 @@ struct usb_device { > unsigned usb2_hw_lpm_besl_capable:1; > unsigned usb2_hw_lpm_enabled:1; > unsigned usb2_hw_lpm_allowed:1; > - unsigned usb3_lpm_enabled:1; > unsigned usb3_lpm_u1_enabled:1; > unsigned usb3_lpm_u2_enabled:1; > int string_langid; You forgot to remove the kerneldoc for this field. And you forgot to add kerneldoc for usb3_lpm_u[12]_enabled. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/