Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752783AbbKKPlm (ORCPT ); Wed, 11 Nov 2015 10:41:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53150 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbbKKPlk (ORCPT ); Wed, 11 Nov 2015 10:41:40 -0500 From: Jeff Moyer To: Jerry.Hoemann@hpe.com Cc: ross.zwisler@linux.intel.com, rjw@rjwysocki.net, lenb@kernel.org, dan.j.williams@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org Subject: Re: [PATCH 2/4] nvdimm: Add IOCTL pass thru References: <4f81a8b6fa24723c808c72888290e2368fcdbca0.1446684001.git.jerry.hoemann@hpe.com> <20151110221352.GE47666@tevye.fc.hp.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Wed, 11 Nov 2015 10:41:37 -0500 In-Reply-To: <20151110221352.GE47666@tevye.fc.hp.com> (Jerry Hoemann's message of "Tue, 10 Nov 2015 15:13:52 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1790 Lines: 47 Jerry Hoemann writes: > On Tue, Nov 10, 2015 at 01:05:20PM -0500, Jeff Moyer wrote: >> Jerry Hoemann writes: >> >> > Add internal data structure for ndctl_passthru call. >> > >> > Signed-off-by: Jerry Hoemann >> > --- >> > include/linux/libnvdimm.h | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/include/linux/libnvdimm.h b/include/linux/libnvdimm.h >> > index 3f021dc..01117e1 100644 >> > --- a/include/linux/libnvdimm.h >> > +++ b/include/linux/libnvdimm.h >> > @@ -72,6 +72,7 @@ struct nvdimm_bus_descriptor { >> > unsigned long dsm_mask; >> > char *provider_name; >> > ndctl_fn ndctl; >> > + ndctl_fn ndctl_passthru; >> >> I don't think this is necessary. Vector off inside of __nd_ioctl. That >> especially makes sense if you do switch to passthrough as a command >> instead of a type, but it can work either way. >> > > In an earlier version, I added a "type" argument to ndctl_fn and switched > internally based upon that. I just came to the conclusion that I'd rather > have two separate acpi_nfit_ctl functions than one trying to do both sets > of argument marshaling. This is quite different both internally and > to the caller. > > So, I thought it would be less confusing to the next engineer, and that > this was a good logical separation point. I'll leave this up to Dan. To me, it doesn't make sense to add a new ioctl function for every new type of ioctl that get's added (assuming more types will follow). Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/