Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752550AbbKKPmx (ORCPT ); Wed, 11 Nov 2015 10:42:53 -0500 Received: from mx2.suse.de ([195.135.220.15]:42739 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbbKKPmv (ORCPT ); Wed, 11 Nov 2015 10:42:51 -0500 Date: Wed, 11 Nov 2015 16:42:49 +0100 From: Petr Mladek To: Jessica Yu Cc: Rusty Russell , Josh Poimboeuf , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Miroslav Benes , linux-api@vger.kernel.org, live-patching@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 4/5] samples: livepatch: init reloc list and mark as klp module Message-ID: <20151111154249.GQ2599@pathway.suse.cz> References: <1447130755-17383-1-git-send-email-jeyu@redhat.com> <1447130755-17383-5-git-send-email-jeyu@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447130755-17383-5-git-send-email-jeyu@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1303 Lines: 34 On Mon 2015-11-09 23:45:54, Jessica Yu wrote: > Intialize the list of relocation sections in the sample > klp_object (even if the list will be empty in this case). > Also mark module as a livepatch module so that the module > loader can appropriately initialize it. > > Signed-off-by: Jessica Yu > --- > samples/livepatch/livepatch-sample.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/samples/livepatch/livepatch-sample.c b/samples/livepatch/livepatch-sample.c > index fb8c861..2ef9345 100644 > --- a/samples/livepatch/livepatch-sample.c > +++ b/samples/livepatch/livepatch-sample.c > @@ -89,3 +90,4 @@ static void livepatch_exit(void) > module_init(livepatch_init); > module_exit(livepatch_exit); > MODULE_LICENSE("GPL"); > +MODULE_INFO(livepatch, "Y"); This looks a bit error prone. I wonder if we could detect this information another way. For example, by a check for the livepatch-related elf sections. If it is missing, we do not need to preserve struct load_info even when it is a livepatch. Best Regards, Petr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/