Date: Wed, 11 Nov 2015 11:33:03 -0500
From: Benjamin LaHaise <bcrl@kvack.org>
To: =?utf-8?B?5YiY6ZW/5Yas?= <liuchangdong007@gmail.com>
Cc: viro@zeniv.linux.org.uk, linux-aio@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aio: Add few code style fixes
Message-ID: <20151111163303.GC25317@kvack.org>
References: <CAPnUq3Qew-ajej5CB44ThGMMXirrd=UA+SbDpXCiv4+bXxTjYw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAPnUq3Qew-ajej5CB44ThGMMXirrd=UA+SbDpXCiv4+bXxTjYw@mail.gmail.com>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2274
Lines: 74

On Wed, Nov 11, 2015 at 11:28:08PM +0800, 刘长冬 wrote:
> >From 1609d68dee344925d182631922cd98790109588b Mon Sep 17 00:00:00 2001
> From: Liu Changdong <liuchangdong007@gmail.com>
> Date: Tue, 10 Nov 2015 00:04:18 +0800
> Subject: [PATCH] aio: Add few code style fixes
> 
> Add a blank line after declarations
> 
> Signed-off-by: Liu Changdong <liuchangdong007@gmail.com>
> ---
>  fs/aio.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/fs/aio.c b/fs/aio.c
> index 155f842..48e4fb0 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -208,6 +208,7 @@ static struct file *aio_private_file(struct kioctx
> *ctx, loff_t nr_pages)
>   struct file *file;
>   struct path path;
>   struct inode *inode = alloc_anon_inode(aio_mnt->mnt_sb);
> +
>   if (IS_ERR(inode))
>   return ERR_CAST(inode);

Your patch is white space damaged.  Please resend in plain text without 
HTML in a format that can be applied using git-am, and test that by sending 
the email to yourself before reposting.

		-ben

> @@ -269,6 +270,7 @@ __initcall(aio_setup);
>  static void put_aio_ring_file(struct kioctx *ctx)
>  {
>   struct file *aio_ring_file = ctx->aio_ring_file;
> +
>   if (aio_ring_file) {
>   truncate_setsize(aio_ring_file->f_inode, 0);
> 
> @@ -293,6 +295,7 @@ static void aio_free_ring(struct kioctx *ctx)
> 
>   for (i = 0; i < ctx->nr_pages; i++) {
>   struct page *page;
> +
>   pr_debug("pid(%d) [%d] page->count=%d\n", current->pid, i,
>   page_count(ctx->ring_pages[i]));
>   page = ctx->ring_pages[i];
> @@ -475,6 +478,7 @@ static int aio_setup_ring(struct kioctx *ctx)
> 
>   for (i = 0; i < nr_pages; i++) {
>   struct page *page;
> +
>   page = find_or_create_page(file->f_inode->i_mapping,
>     i, GFP_HIGHUSER | __GFP_ZERO);
>   if (!page)
> @@ -1352,6 +1356,7 @@ out:
>  SYSCALL_DEFINE1(io_destroy, aio_context_t, ctx)
>  {
>   struct kioctx *ioctx = lookup_ioctx(ctx);
> +
>   if (likely(NULL != ioctx)) {
>   struct ctx_rq_wait wait;
>   int ret;
> -- 
> 2.1.4

-- 
"Thought is the essence of where you are now."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/