Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752274AbbKKQ7w (ORCPT ); Wed, 11 Nov 2015 11:59:52 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:34572 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751414AbbKKQ7u (ORCPT ); Wed, 11 Nov 2015 11:59:50 -0500 Date: Wed, 11 Nov 2015 16:59:47 +0000 From: Matt Fleming To: Geliang Tang Cc: Anton Vorontsov , Colin Cross , Kees Cook , Tony Luck , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit() Message-ID: <20151111165947.GD4889@codeblueprint.co.uk> References: <337377a3fbcf855d6a5217e06fcd8c8a979f2853.1446869434.git.geliangtang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1233 Lines: 36 On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: > The original efivars_pstore_exit() is empty. I > 1) add a bufsize check statement. > 2) call pstore_unregister as it is defined now. > 3) free the memory and set bufsize to 0. > > Signed-off-by: Geliang Tang > --- > drivers/firmware/efi/efi-pstore.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c > index eac76a7..62d57d8 100644 > --- a/drivers/firmware/efi/efi-pstore.c > +++ b/drivers/firmware/efi/efi-pstore.c > @@ -393,6 +393,13 @@ static __init int efivars_pstore_init(void) > > static __exit void efivars_pstore_exit(void) > { > + if (!efi_pstore_info.bufsize) > + return; > + > + pstore_unregister(&efi_pstore_info); > + kfree(efi_pstore_info.buf); > + efi_pstore_info.buf = NULL; > + efi_pstore_info.bufsize = 0; > } > > module_init(efivars_pstore_init); Looks OK to me. Kees, are you picking this up? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/