Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbbKKRdi (ORCPT ); Wed, 11 Nov 2015 12:33:38 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:37265 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752428AbbKKRdg (ORCPT ); Wed, 11 Nov 2015 12:33:36 -0500 MIME-Version: 1.0 In-Reply-To: <20151111173100.GA20846@kroah.com> References: <1447237306-46901-1-git-send-email-shivanib134@gmail.com> <201511111859.mIw4mICa%fengguang.wu@intel.com> <20151111173100.GA20846@kroah.com> Date: Wed, 11 Nov 2015 23:03:34 +0530 Message-ID: Subject: Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper From: Shivani Bhardwaj To: Greg KH Cc: kbuild test robot , kbuild-all@01.org, "Drokin, Oleg" , devel@driverdev.osuosl.org, "Dilger, Andreas" , linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4194 Lines: 76 On Wed, Nov 11, 2015 at 11:01 PM, Greg KH wrote: > On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote: >> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot wrote: >> > Hi Shivani, >> > >> > [auto build test ERROR on staging/staging-testing] >> > [also build test ERROR on v4.3 next-20151111] >> > >> > url: https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-cl_lock-Remove-cl_lock_lockdep_init-wrapper/20151111-182452 >> > config: m68k-allyesconfig (attached as .config) >> > reproduce: >> > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross >> > chmod +x ~/bin/make.cross >> > # save the attached .config to linux build tree >> > make.cross ARCH=m68k >> > >> > All errors (new ones prefixed by >>): >> > >> > In file included from include/linux/spinlock_types.h:18:0, >> > from include/linux/spinlock.h:81, >> > from include/linux/mmzone.h:7, >> > from include/linux/gfp.h:5, >> > from include/linux/slab.h:14, >> > from drivers/staging/lustre/lustre/obdclass/../include/obd_support.h:40, >> > from drivers/staging/lustre/lustre/obdclass/../include/obd_class.h:39, >> > from drivers/staging/lustre/lustre/obdclass/cl_lock.c:43: >> > drivers/staging/lustre/lustre/obdclass/cl_lock.c: In function 'cl_lock_alloc': >> >>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: error: 'cl_lock_key' undeclared (first use in this function) >> > lockdep_set_class_and_name(lock, &cl_lock_key, "EXT"); >> > ^ >> > include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name' >> > do { (void)(key); (void)(name); } while (0) >> > ^ >> > drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: note: each undeclared identifier is reported only once for each function it appears in >> > lockdep_set_class_and_name(lock, &cl_lock_key, "EXT"); >> > ^ >> > include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name' >> > do { (void)(key); (void)(name); } while (0) >> > ^ >> > drivers/staging/lustre/lustre/obdclass/cl_lock.c: At top level: >> > drivers/staging/lustre/lustre/obdclass/cl_lock.c:166:13: warning: 'cl_lock_lockdep_init' defined but not used [-Wunused-function] >> > static void cl_lock_lockdep_init(struct cl_lock *lock) >> > ^ >> > >> > vim +/cl_lock_key +379 drivers/staging/lustre/lustre/obdclass/cl_lock.c >> > >> > 373 lockdep_set_class(&lock->cll_guard, &cl_lock_guard_class); >> > 374 init_waitqueue_head(&lock->cll_wq); >> > 375 head = obj->co_lu.lo_header; >> > 376 CS_LOCKSTATE_INC(obj, CLS_NEW); >> > 377 CS_LOCK_INC(obj, total); >> > 378 CS_LOCK_INC(obj, create); >> > > 379 lockdep_set_class_and_name(lock, &cl_lock_key, "EXT"); >> > 380 list_for_each_entry(obj, &head->loh_layers, >> > 381 co_lu.lo_linkage) { >> > 382 int err; >> > >> > --- >> > 0-DAY kernel test infrastructure Open Source Technology Center >> > https://lists.01.org/pipermail/kbuild-all Intel Corporation >> >> Hi all, >> >> I'm not getting any of these errors at compilation. I've checked >> thrice. Could you please tell what am I doing wrong so that I can >> avoid introducing errors in future patches? > > Use the .config provided, odds are you have lockdep enabled. Thanks Greg. I tried that. Still no errors. Any other suggestion? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/