Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752067AbbKKSCc (ORCPT ); Wed, 11 Nov 2015 13:02:32 -0500 Received: from mail-lf0-f41.google.com ([209.85.215.41]:34722 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbbKKSCa (ORCPT ); Wed, 11 Nov 2015 13:02:30 -0500 Subject: Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface To: Felipe Ferreri Tonello , linux-usb@vger.kernel.org References: <1447177929-22252-1-git-send-email-eu@felipetonello.com> <1447177929-22252-7-git-send-email-eu@felipetonello.com> <56423AB6.5090808@cogentembedded.com> <56430C99.2080703@felipetonello.com> Cc: linux-kernel@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , Robert Baldyga , Clemens Ladisch From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <564382B2.7020001@cogentembedded.com> Date: Wed, 11 Nov 2015 21:02:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56430C99.2080703@felipetonello.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1627 Lines: 51 Hello. On 11/11/2015 12:38 PM, Felipe Ferreri Tonello wrote: >>> This avoids duplication of USB requests for OUT endpoint and >>> re-enabling endpoints. >>> >>> Signed-off-by: Felipe F. Tonello >>> --- >>> drivers/usb/gadget/function/f_midi.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/usb/gadget/function/f_midi.c >>> b/drivers/usb/gadget/function/f_midi.c >>> index 76ea53c..615d632 100644 >>> --- a/drivers/usb/gadget/function/f_midi.c >>> +++ b/drivers/usb/gadget/function/f_midi.c >>> @@ -75,6 +75,7 @@ struct f_midi { >>> struct usb_ep *in_ep, *out_ep; >>> struct snd_card *card; >>> struct snd_rawmidi *rmidi; >>> + u8 ms_id; >> >> Why 'ms_id' is not aligned with the above field names? > > It is actually aligned. Perhaps because of the +? No, + should not affect this, it only affects things when a line doesn't start with a tab. > Here is from my local git diff: > > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -75,6 +75,7 @@ struct f_midi { > struct usb_ep *in_ep, *out_ep; > struct snd_card *card; > struct snd_rawmidi *rmidi; > + u8 ms_id; Unfortunately, tabs got replaces with spaces in this fragment. [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/