Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752783AbbKKUnh (ORCPT ); Wed, 11 Nov 2015 15:43:37 -0500 Received: from mail.kernel.org ([198.145.29.136]:54519 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752581AbbKKUnf (ORCPT ); Wed, 11 Nov 2015 15:43:35 -0500 MIME-Version: 1.0 In-Reply-To: <009301d11c4c$6eaa1eb0$4bfe5c10$@samsung.com> References: <0bc58ce0fd39767834f486c4c0cfbbd70044caed.1446799912.git.p.fedin@samsung.com> <009301d11c4c$6eaa1eb0$4bfe5c10$@samsung.com> From: Rob Herring Date: Wed, 11 Nov 2015 14:43:12 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 1/4] Documentation: dt-bindings: Describe SROMc configuration To: Pavel Fedin Cc: "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Kukjin Kim , Krzysztof Kozlowski Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1806 Lines: 33 On Wed, Nov 11, 2015 at 12:44 AM, Pavel Fedin wrote: > Hello! > >> > +- samsung,srom-timing : array of 6 integers, specifying bank timings in the >> > + following order: Tacp, Tcah, Tcoh, Tacc, Tcos, Tacs. >> > + Each value is specified in cycles and has the following >> > + meaning and valid range: >> > + Tacp : Page mode access cycle at Page mode (0 - 15) >> > + Tcah : Address holding time after CSn (0 - 15) >> > + Tcoh : Chip selection hold on OEn (0 - 15) >> > + Tacc : Access cycle (0 - 31, the actual time is N + 1) >> > + Tcos : Chip selection set-up before OEn (0 - 15) >> > + Tacs : Address set-up before CSn (0 - 15) >> >> This is not easily extended. Perhaps a property per value instead. > > We had a discussion with Krzysztof about it, he agreed with this form of the property. > My concern was that it's just too much typing, and makes little sense because these > settings always go together. If register layout changes, or parameter set changes in > incompatible way, then it's another device, not exynos-srom anymore. > So would you agree with that, or is your position strong? I'm thinking for a new version of the controller which could add (or remove) new timing parameters, but then I guess you can interpret the field differently based on the compatible string. Anyway, your problem to deal with. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/