Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752773AbbKKWHE (ORCPT ); Wed, 11 Nov 2015 17:07:04 -0500 Received: from ozlabs.org ([103.22.144.67]:53523 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479AbbKKWHB (ORCPT ); Wed, 11 Nov 2015 17:07:01 -0500 Date: Thu, 12 Nov 2015 09:06:58 +1100 From: Stephen Rothwell To: Eduardo Valentin Cc: Caesar Wang , rui.zhang@intel.com, heiko@sntech.de, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org, lkp@intel.com Subject: Re: [PATCH] thermal: rockchip: fix compile error Message-ID: <20151112090658.619c3b7c@canb.auug.org.au> In-Reply-To: <20151109193638.GB10824@localhost.localdomain> References: <1446990043-8096-1-git-send-email-wxt@rock-chips.com> <20151109193638.GB10824@localhost.localdomain> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1476 Lines: 39 Hi Eduardo, On Mon, 9 Nov 2015 11:36:39 -0800 Eduardo Valentin wrote: > > On Sun, Nov 08, 2015 at 09:40:43PM +0800, Caesar Wang wrote: > > Missing a include file caused compile error. > > > > drivers/thermal/rockchip_thermal.c: > > In function 'rockchip_thermal_suspend': > > drivers/thermal/rockchip_thermal.c:720:2: error: implicit > > declaration of function 'pinctrl_pm_select_sleep_state' > > [-Werror=implicit-function-declaration] > > pinctrl_pm_select_sleep_state(dev); > > ^ > > drivers/thermal/rockchip_thermal.c: > > In function 'rockchip_thermal_resume': > > drivers/thermal/rockchip_thermal.c:759:2: error: implicit > > declaration of function 'pinctrl_pm_select_default_state' > > [-Werror=implicit-function-declaration] > > ^pinctrl_pm_select_default_state(dev); > > cc1: some warnings being treated as errors > > > > Fixes: 7e38a5b1daa1 ("thermal: rockchip: support the sleep pinctrl state > > to avoid glitches") > > > Adding this to my tree and sending to ruis too. This missed the merge of the thermal tree into Linus' tree and so is now needed in Linus' tree ASAP (several builds are failing). -- Cheers, Stephen Rothwell sfr@canb.auug.org.au -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/