Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753340AbbKKWWS (ORCPT ); Wed, 11 Nov 2015 17:22:18 -0500 Received: from down.free-electrons.com ([37.187.137.238]:36845 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753074AbbKKWWO (ORCPT ); Wed, 11 Nov 2015 17:22:14 -0500 Date: Wed, 11 Nov 2015 14:22:10 -0800 From: Maxime Ripard To: Herbert Xu Cc: Christoph Biedl , clabbe.montjoie@gmail.com, davem@davemloft.net, wens@csie.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, stable@vger.kernel.org Subject: Re: [PATCH] crypto: sun4i-ss: add missing statesize Message-ID: <20151111222210.GI6114@lukather> References: <1447006457@msgid.manchmal.in-ulm.de> <20151109035848.GA2163@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LFN/h9p3ZzIorjyq" Content-Disposition: inline In-Reply-To: <20151109035848.GA2163@gondor.apana.org.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2318 Lines: 64 --LFN/h9p3ZzIorjyq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 09, 2015 at 11:58:48AM +0800, Herbert Xu wrote: > Christoph Biedl wrote: > > > > Fixes: should rather point to the commit that caused the breakage in my > > opinion. Which did this by intention: >=20 > Absolutely not. That patch is correct and if you revert that > you will simply end up registering a broken driver into the system > that may then lead to crashes that can be triggered from user-space. Yeah my point was that the commit log should be something like """ sun4i-ss implementaton of md5/sha1 is via ahash algorithms. Commit 8996eafdcbad ('crypto: ahash - ensure statesize is non-zero') made impossible to load them without giving statesize. This patch specifiy statesize for sha1 and md5. Fixes: 6298e948215f ("crypto: sunxi-ss - Add Allwinner Security System cryp= to accelerator") """ Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --LFN/h9p3ZzIorjyq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWQ7+SAAoJEBx+YmzsjxAgjYgP/j+ql8UWunnNDfiBnksrSBCU +fm0kEMi0JXOfJNW7bbEmP5w7g6/qlKe2MJ6txdNYr6x6EcsxOtc75n1KlJkc6n6 Wa2SMGKeiwn4bY5hEfOYu/4Pkm9CmMzxmRSLpuR0JmlNJh12coNVe/7nNZPMVe4z o0H44Sa6ZW790LoKz5elzfiqlQSshPsgat5nNA+UC3V2pXRh7uglK+2WQLRwrqdc 7vIGJT3pxUVMQlF0f+k8EeMfAEyn05dTka6O7dn6568fxZaQ6Yml0k2fAmJcUJNe eTu5qt4f3oVhLhsm0Fkp3oeLWH0jXc81GPswA0kkAFc6DqBYZ3uvXt9lDPDO+YAd 5HI0F8x+fQqTyAii5pLpl5QnGiNHYcLJn0Pz9GBkyzqvSPs4MiApn8EueChBlSWe UcdVm0oDebUUcDyVLnGZA+6A6NHl+cui1wEXH+U6JKM05sf5Hpu3OiR0nznLa6gH gCZ2tkzSEwnpkLd5+3KRnoUneLiTsWqvL/WCyEkXFKlBUpQ0CFF1mT0icOZkSoT/ hUVqxZtudziNlLQe6iE8K4RURaU0R5Iilig8qLrbjHV3AZwsNWaNIT3eUDmb40bc 93cUYhrAFRJupZYkDzKRSfMB2+kpVM2c2CKwvzVIl7YDyar6COcWiao5BenbdvW2 UCTMfXfznWqZHPRw2X08 =Z8F/ -----END PGP SIGNATURE----- --LFN/h9p3ZzIorjyq-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/