Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752668AbbKLAyA (ORCPT ); Wed, 11 Nov 2015 19:54:00 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:36742 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752609AbbKLAx6 (ORCPT ); Wed, 11 Nov 2015 19:53:58 -0500 Date: Thu, 12 Nov 2015 09:54:55 +0900 From: Sergey Senozhatsky To: David Rientjes Cc: Sergey Senozhatsky , Andrew Morton , Christoph Lameter , Pekka Enberg , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 2/3] tools/vm/page-types: suppress gcc warnings Message-ID: <20151112005455.GA1651@swordfish> References: <1447162326-30626-1-git-send-email-sergey.senozhatsky@gmail.com> <1447162326-30626-3-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1788 Lines: 56 On (11/11/15 12:44), David Rientjes wrote: [..] > This can't possibly be correct, the warnings are legitimate and the result > of the sigsetjmp() in the function. You may be interested in > returns_twice rather than marking random automatic variables as volatile. Hm, ok. I saw no probs with `int first' and `end' being volatile static void walk_file(const char *name, const struct stat *st) { int first = 1; for (...) { if (sigsetjmp(sigbus_jmp, 1)) { goto got_sigbus; } got_sigbus: ... if (first && opt_list) { first = 0; print_foo(); } } } the `end' is also looked fine. ANSI C ?7.13.2.1 3 All accessible objects have values, and all other components of the abstract machine 249) have state, as of the time the longjmp function was called, except that the values of objects of automatic storage duration that are local to the function containing the invocation of the corresponding setjmp macro that do not have volatile-qualified type ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ and have been changed between the setjmp invocation and longjmp call are indeterminate. Thus, adding 'volatile' should do the trick. Isn't it? I need to google more - is returns_twice actually prevents gcc from `over-optimizing' (there are some bug reports that state that setjmp can be screwed up by gcc) or it's actually because the programs that do setjmp basically violate ANSI C standard and don't volatile-qualify the affected variables. Any hint would be helpful. -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/