Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752832AbbKLBMw (ORCPT ); Wed, 11 Nov 2015 20:12:52 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:36509 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752266AbbKLBMv (ORCPT ); Wed, 11 Nov 2015 20:12:51 -0500 Date: Thu, 12 Nov 2015 10:13:47 +0900 From: Sergey Senozhatsky To: David Rientjes Cc: Sergey Senozhatsky , Andrew Morton , Christoph Lameter , Pekka Enberg , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 3/3] tools/vm/slabinfo: update struct slabinfo members' types Message-ID: <20151112011347.GC1651@swordfish> References: <1447162326-30626-1-git-send-email-sergey.senozhatsky@gmail.com> <1447162326-30626-4-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 895 Lines: 27 On (11/11/15 12:55), David Rientjes wrote: [..] > > /* Object size */ > > - unsigned long long min_objsize = max, max_objsize = 0, avg_objsize; > > + unsigned int min_objsize = UINT_MAX, max_objsize = 0, avg_objsize; > > > > /* Number of partial slabs in a slabcache */ > > unsigned long long min_partial = max, max_partial = 0, > > avg_objsize should not be unsigned int. Hm. the assumption is that `avg_objsize' cannot be larger than `max_objsize', which is `int object_size;' in `struct kmem_cache' from slab_def.h and `unsigned int object_size;' in `struct kmem_cache' from slab.h. avg_objsize = total_used / total_objects; -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/