Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752892AbbKLCRl (ORCPT ); Wed, 11 Nov 2015 21:17:41 -0500 Received: from mga14.intel.com ([192.55.52.115]:10935 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752513AbbKLCRk (ORCPT ); Wed, 11 Nov 2015 21:17:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,279,1444719600"; d="scan'208";a="834922928" Subject: Re: [PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device To: Alan Stern References: Cc: Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: "Lu, Baolu" Message-ID: <5643F6C4.6060709@linux.intel.com> Date: Thu, 12 Nov 2015 10:17:40 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1493 Lines: 49 On 11/11/2015 11:10 PM, Alan Stern wrote: > On Wed, 11 Nov 2015, Lu Baolu wrote: > >> Commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical sections.") >> adds usb3_lpm_enabled member to struct usb_device. There is no reference >> to this member now. Hence, it could be removed. >> >> Signed-off-by: Lu Baolu >> --- >> include/linux/usb.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/linux/usb.h b/include/linux/usb.h >> index 211664f..036e4a5 100644 >> --- a/include/linux/usb.h >> +++ b/include/linux/usb.h >> @@ -583,7 +583,6 @@ struct usb_device { >> unsigned usb2_hw_lpm_besl_capable:1; >> unsigned usb2_hw_lpm_enabled:1; >> unsigned usb2_hw_lpm_allowed:1; >> - unsigned usb3_lpm_enabled:1; >> unsigned usb3_lpm_u1_enabled:1; >> unsigned usb3_lpm_u2_enabled:1; >> int string_langid; > You forgot to remove the kerneldoc for this field. And you forgot to > add kerneldoc for usb3_lpm_u[12]_enabled. Yes. I will fix this in v2. > > Alan Stern Thanks, Baolu > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/