Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753244AbbKLE35 (ORCPT ); Wed, 11 Nov 2015 23:29:57 -0500 Received: from smtprelay4.synopsys.com ([198.182.47.9]:49011 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752991AbbKLE3z convert rfc822-to-8bit (ORCPT ); Wed, 11 Nov 2015 23:29:55 -0500 From: John Youn To: Doug Anderson , Yunzhi Li CC: John Youn , Julius Werner , Dinh Nguyen , "Kaukab, Yousaf" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , wulf , Kever Yang , caesar , Tao Huang , rockchip-discuss Subject: Re: [RFC] usb: dwc2: hcd: fix split schedule issue Thread-Topic: [RFC] usb: dwc2: hcd: fix split schedule issue Thread-Index: AQHRGHbnZi8mHX/q8ECLIM60EIOt9w== Date: Thu, 12 Nov 2015 04:29:52 +0000 Message-ID: <2B3535C5ECE8B5419E3ECBE30077290901DC3C8CA4@US01WEMBX2.internal.synopsys.com> References: <1446802612-5828-1-git-send-email-lyz@rock-chips.com> <563C7B48.2020308@rock-chips.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.161.109] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2080 Lines: 61 On 11/11/2015 4:22 PM, Doug Anderson wrote: > John, > > On Fri, Nov 6, 2015 at 2:04 AM, Yunzhi Li wrote: >> hi John , >> >> As we talked yesterday, I tried to fix the split schedule sequence. This >> patch will >> avoid scheduling SSPLIT-IN packet for another device between >> SSPLIT-OUT-begin and >> SSPLIT-OUT-end, now the keyboard and Jebra audio speaker could work together >> well, but >> I'm not sure if this is exactly the right way to schedule split transfers >> and if there >> is any dide effect with this patch. Please help review this patch. Thanks. >> >>> Fix dwc2 split schedule sequence issue. Not schedule a SSPLIT_IN >>> packet between SSPLIT-begin and SSPLIT-end. >>> >>> Signed-off-by: Yunzhi Li >>> --- >>> drivers/usb/dwc2/hcd.c | 4 ++++ >>> 1 file changed, 4 insertions(+) > > Did you have any thoughts on this patch? Although this patch didn't > fix the problems I was seeing with the Microsoft Wireless Keyboard > (see the patch I sent out earlier which does seem to fix it), I can > confirm that in a different setup (HUB goes to USB audio + mouse) that > this patch does fix some problems. > > That being said, it feels to me like a band-aid rather than an actual > fix (I'm talking out of my rear end, though, since my USB experience > is lacking at best). It feels like perhaps we're just not keeping > track the xact_pos correctly, but of course I don't know that for > sure... > > Anyway, just fishing... ;) > > -Doug > Hi Doug, I also feel it is not quite right as the SSPLIT should be able to happen during the SSPLIT of another device. I tried to reproduce and see the same scheduling but don't see any hang due to it. Yunzhi, any details on what kind of hub and keyboard you are using? I have the same Jabra 410 speaker. Regards, John -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/