Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753541AbbKLH0O (ORCPT ); Thu, 12 Nov 2015 02:26:14 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:32981 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753158AbbKLH0J (ORCPT ); Thu, 12 Nov 2015 02:26:09 -0500 From: LABBE Corentin To: gnurou@gmail.com, ldewangan@nvidia.com, swarren@wwwdotorg.org, thierry.reding@gmail.com, wsa@the-dreams.de Cc: LABBE Corentin , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH] i2c: tegra: fix a possible NULL dereference Date: Thu, 12 Nov 2015 08:26:03 +0100 Message-Id: <1447313163-23848-1-git-send-email-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.4.10 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1065 Lines: 32 of_match_device could return NULL, and so cause a NULL pointer dereference later at line 809: i2c_dev->hw = match->data; Signed-off-by: LABBE Corentin --- drivers/i2c/busses/i2c-tegra.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index a0522fc..c803551 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -806,7 +806,10 @@ static int tegra_i2c_probe(struct platform_device *pdev) if (pdev->dev.of_node) { const struct of_device_id *match; + match = of_match_device(tegra_i2c_of_match, &pdev->dev); + if (!match) + return -ENODEV; i2c_dev->hw = match->data; i2c_dev->is_dvc = of_device_is_compatible(pdev->dev.of_node, "nvidia,tegra20-i2c-dvc"); -- 2.4.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/