Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753811AbbKLHqu (ORCPT ); Thu, 12 Nov 2015 02:46:50 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:51093 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753573AbbKLHqt (ORCPT ); Thu, 12 Nov 2015 02:46:49 -0500 Date: Thu, 12 Nov 2015 08:46:43 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: LABBE Corentin Cc: jdelvare@suse.com, wsa@the-dreams.de, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: taos-evm: replace simple_strtoul by kstrtou8 Message-ID: <20151112074643.GB24008@pengutronix.de> References: <1447313194-23931-1-git-send-email-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1447313194-23931-1-git-send-email-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1671 Lines: 46 On Thu, Nov 12, 2015 at 08:26:33AM +0100, LABBE Corentin wrote: > The simple_strtoul function is marked as obsolete. > This patch replace it by kstrtou8. > > Signed-off-by: LABBE Corentin > --- > drivers/i2c/busses/i2c-taos-evm.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c > index 4c7fc2d..fe2b705 100644 > --- a/drivers/i2c/busses/i2c-taos-evm.c > +++ b/drivers/i2c/busses/i2c-taos-evm.c > @@ -70,6 +70,7 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, > struct serio *serio = adapter->algo_data; > struct taos_data *taos = serio_get_drvdata(serio); > char *p; > + int err; > > /* Encode our transaction. "@" is for the device address, "$" for the > SMBus command and "#" for the data. */ > @@ -130,7 +131,9 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, > return 0; > } else { > if (p[0] == 'x') { > - data->byte = simple_strtol(p + 1, NULL, 16); > + err = kstrtou8(p + 1, 16, &data->byte); > + if (err) > + return -EPROTO; > return 0; This is nearly equivalent to the probably more correct: return kstrtou8(p + 1, 16, &data->byte); Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/