Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754161AbbKLNl0 (ORCPT ); Thu, 12 Nov 2015 08:41:26 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:8251 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753763AbbKLNlD (ORCPT ); Thu, 12 Nov 2015 08:41:03 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 12 Nov 2015 05:29:54 -0800 Subject: Re: [PATCH] i2c: tegra: fix a possible NULL dereference To: Thierry Reding , LABBE Corentin References: <1447313163-23848-1-git-send-email-clabbe.montjoie@gmail.com> <20151112122923.GA31671@ulmo> CC: , , , , , , From: Jon Hunter Message-ID: <564496E8.60106@nvidia.com> Date: Thu, 12 Nov 2015 13:40:56 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151112122923.GA31671@ulmo> X-Originating-IP: [10.21.132.159] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 39 On 12/11/15 12:29, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Thu, Nov 12, 2015 at 08:26:03AM +0100, LABBE Corentin wrote: >> of_match_device could return NULL, and so cause a NULL pointer > > No. There is no way that of_match_device() can ever fail. The driver > core uses the same table to match the OF device to the driver, so the > only case where of_match_device() would return NULL is if no match was > found, in which case the tegra_i2c_probe() function would never have > been called in the first place. Right and so ... >> dereference later at line 809: >> i2c_dev->hw = match->data; >> >> Signed-off-by: LABBE Corentin >> --- >> drivers/i2c/busses/i2c-tegra.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c >> index a0522fc..c803551 100644 >> --- a/drivers/i2c/busses/i2c-tegra.c >> +++ b/drivers/i2c/busses/i2c-tegra.c >> @@ -806,7 +806,10 @@ static int tegra_i2c_probe(struct platform_device *pdev) >> >> if (pdev->dev.of_node) { Can we get rid of this if-statement? Jon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/