Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754366AbbKLOQE (ORCPT ); Thu, 12 Nov 2015 09:16:04 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35530 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753326AbbKLOQB (ORCPT ); Thu, 12 Nov 2015 09:16:01 -0500 Subject: Re: [PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data To: Tony Lindgren References: <5628A9F2.3010801@baylibre.com> <20151024012112.GA3078@atomide.com> Cc: Paul Walmsley , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Hutchinson , Frode Isaksen From: Neil Armstrong Organization: Baylibre Message-ID: <56449F15.10508@baylibre.com> Date: Thu, 12 Nov 2015 15:15:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2632 Lines: 82 On 10/24/2015 12:09 PM, Neil Armstrong wrote: > Hi, > > 2015-10-24 3:21 GMT+02:00 Tony Lindgren : >> >> Hi, >> >> * Neil Armstrong [151022 02:19]: >>> Add missing HWMOD_NO_IDLEST hwmod flag for entries no >>> having omap4 clkctrl values. >> >> Have you checked this is the case both in dm814x and dm816x TRM? >> Also the documentation may not be complete FYI, might be also >> worth checking the legacy TI kernel tree to be sure. >> >> Regards, >> >> Tony >> >>> Cc: Brian Hutchinson >>> Signed-off-by: Neil Armstrong >>> --- >>> arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c >>> index b1288f5..6256052 100644 >>> --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c >>> +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c >>> @@ -144,6 +144,7 @@ static struct omap_hwmod dm81xx_l4_ls_hwmod = { >>> .name = "l4_ls", >>> .clkdm_name = "alwon_l3s_clkdm", >>> .class = &l4_hwmod_class, >>> + .flags = HWMOD_NO_IDLEST, >>> }; > In DM814x TRM, the CM_ALWON_L3_SLOW_CLKSTCTRL does not have IDLEST field. > Same in DM816x TRM. > >>> >>> /* >>> @@ -155,6 +156,7 @@ static struct omap_hwmod dm81xx_l4_hs_hwmod = { >>> .name = "l4_hs", >>> .clkdm_name = "alwon_l3_med_clkdm", >>> .class = &l4_hwmod_class, >>> + .flags = HWMOD_NO_IDLEST, >>> }; > In DM814x TRM, the CM_ALWON_L3_MED_CLKSTCTRL does not have IDLEST field. > Same in DM816x TRM. > >>> >>> /* L3 slow -> L4 ls peripheral interface running at 125MHz */ >>> @@ -850,6 +852,7 @@ static struct omap_hwmod dm816x_emac0_hwmod = { >>> .name = "emac0", >>> .clkdm_name = "alwon_ethernet_clkdm", >>> .class = &dm816x_emac_hwmod_class, >>> + .flags = HWMOD_NO_IDLEST, >>> }; > In this particular case, the IDLEST is handled in the MDIO hwmod. > >>> >>> static struct omap_hwmod_ocp_if dm81xx_l4_hs__emac0 = { >>> -- >>> 1.9.1 > > I'll check the TI tree to be sure... > > Regards, > Neil > Tony, In TI's tree, there is no L3_MED hwmod but the L3_SLOW hwmod has NO_IDLEST flag. Is there any other issue about this patchset ? Neil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/