Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754772AbbKLPdr (ORCPT ); Thu, 12 Nov 2015 10:33:47 -0500 Received: from g2t2352.austin.hp.com ([15.217.128.51]:37701 "EHLO g2t2352.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752436AbbKLPdq (ORCPT ); Thu, 12 Nov 2015 10:33:46 -0500 Date: Thu, 12 Nov 2015 08:33:42 -0700 From: Jerry Hoemann To: Dmitry Krivenok Cc: ross.zwisler@linux.intel.com, rjw@rjwysocki.net, Len Brown , dan.j.williams@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org Subject: Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru Message-ID: <20151112153342.GA129240@tevye.fc.hp.com> Reply-To: Jerry.Hoemann@hpe.com References: <20151109215904.GB33245@tevye.fc.hp.com> <20151111214435.GB95024@tevye.fc.hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 929 Lines: 20 On Thu, Nov 12, 2015 at 12:52:47AM +0300, Dmitry Krivenok wrote: > > but, we still want to go through entire list. > > Shouldn't you break the loop immediately after you found the bus and sent ioctl? > Maybe I'm missing something, but I see no reason to continue iterating > after the bus was found (even though you don't do anything and just > compare IDs and "continue"). okay, i understand now what you're saying. i'll address in version 2. -- ----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett-Packard Enterprise ----------------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/