Date: Thu, 12 Nov 2015 11:12:46 -0500
From: "Chen, Gong" <gong.chen@linux.intel.com>
To: Tony Luck <tony.luck@intel.com>
Cc: bp@alien8.de, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors
 into the genpool.
Message-ID: <20151112161246.GA14184@gchen.bj.intel.com>
References: <20151111193845.GA9055@agluck-desk.sc.intel.com>
 <3165a4989dcb45fc0306438d40d0cf2ace429c4c.1447280215.git.tony.luck@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO"
Content-Disposition: inline
In-Reply-To: <3165a4989dcb45fc0306438d40d0cf2ace429c4c.1447280215.git.tony.luck@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2678
Lines: 65


--M9NhX3UHpAaciwkO
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 11, 2015 at 02:01:51PM -0800, Luck, Tony wrote:
> Date: Wed, 11 Nov 2015 14:01:51 -0800
> From: Tony Luck <tony.luck@intel.com>
> To: "Chen, Gong" <gong.chen@linux.intel.com>
> Cc: bp@alien8.de, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
> Subject: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors
>  into the genpool.
>=20
> We used to have a special ring buffer for deferred errors that
> was used to mark problem pages. We replaced that with a genpool.
> Then later converted mce_log() to also use the same genpool. As
> a result we end up adding all deferred errors to the genpool twice.
>=20
> Rearrange this code. Make sure to set the m.severity and m.usable_addr
> fields for deferred errors. Then if flags and mca_cfg.dont_log_ce mean
> we call mce_log() we are done, because that will add this entry to the
> genpool.
>=20
> If we skipped mce_log(), then we still want to take action for the
> deferred error, so add to the genpool.
>=20
> Changed the name of the boolean "error_logged" to "error_seen", we
> should set it whether of not we logged an error because the return
> value from machine_check_poll() is used to decide whether storms
> have subsided or not.
>=20
> Reported-by: Chen, Gong <gong.chen.linux.intel.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---

It's much better than my original version.

--M9NhX3UHpAaciwkO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJWRLp+AAoJEI01n1+kOSLHxZIQALjEvbDWV9/a5OTZbPN3H7KM
wIWS08ZaohqJf2kGtzRKdmmQUGkWMxCKsjMV97I1EuHjHYd/4FyYdW0vRW5LhLox
n7ssg7GQ1VIh7f0UMZoFPgMPmHRoVsgDG7Do5GpQYGWdpRmFEyVUPOOggKSYaZVS
NYqtezMcmKK8Piyrb7gxv1Zoytllor3PYwDY/bErUiH71M2X7B4b9GrKw9YbsF9m
HkJ0B+dZ9NVhuHJOmduy1SHAbxjZOOid8FNfF/VBaNkiNhRmZ3AL0IIzN9BhZhq4
ORCVBWVRXUGoPTMdbGgh2tWds4r+eGAPzPgq4+qXh2VPiWtTNrftMvRuqf0nM8At
mw5FM1RueAINgif66PTIek+8wzD69cgjm6646LOR7gOqE6WlJZx68IKO3EaSTM3n
7FtItrEFuZ5Uo11oQBhpfq82H3nWJh0dNAX0GiGqwcDC1pCLlPrp0BZqnshtX7pe
eQo6Z2lLSU5FJYs5dOCiHOAZmdqBCK356s5SD05zSW1kOJR5LKfXickM6u9udBQ2
RbKUtu7oMTsbACiJW5EykUwJaYwMHvqOKaEDX0vpeCDpEWFMfeG04XBobMzsNK5e
Gl9N8qkX2sXD7M9VBUr2X89N7oiutCI+PiQ3wnWHdD/syizEyxYicSzdnngs1mU8
VcNDIJAyFRCAR9IJfEqp
=wA0E
-----END PGP SIGNATURE-----

--M9NhX3UHpAaciwkO--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/