Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932269AbbKLSmX (ORCPT ); Thu, 12 Nov 2015 13:42:23 -0500 Received: from mail-ob0-f169.google.com ([209.85.214.169]:34393 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932119AbbKLSmU convert rfc822-to-8bit (ORCPT ); Thu, 12 Nov 2015 13:42:20 -0500 MIME-Version: 1.0 In-Reply-To: <1447353300-26027-1-git-send-email-m@bjorling.me> References: <1447353300-26027-1-git-send-email-m@bjorling.me> Date: Thu, 12 Nov 2015 19:42:19 +0100 X-Google-Sender-Auth: UVrRH3PSQDyUNJvnpmHs7A5zirM Message-ID: Subject: Re: [PATCH] lightnvm: change max_phys_sect to ushort From: Geert Uytterhoeven To: =?UTF-8?Q?Matias_Bj=C3=B8rling?= Cc: linux-block@vger.kernel.org, "linux-kernel@vger.kernel.org" , Jens Axboe Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1558 Lines: 41 On Thu, Nov 12, 2015 at 7:35 PM, Matias Bjørling wrote: > The max_phys_sect variable is defined as a char. We do a boundary check > to maximally allow 256 physical page descriptors per command. As we are > not indexing from zero. This expression is always in false. Bump the > max_phys_sect to an unsigned short to support the range check. unsigned int? > > Signed-off-by: Matias Bjørling > Reported-by: Geert Uytterhoeven > --- > include/linux/lightnvm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h > index 69c9057..4b1cd3d 100644 > --- a/include/linux/lightnvm.h > +++ b/include/linux/lightnvm.h > @@ -220,7 +220,7 @@ struct nvm_dev_ops { > nvm_dev_dma_alloc_fn *dev_dma_alloc; > nvm_dev_dma_free_fn *dev_dma_free; > > - uint8_t max_phys_sect; > + unsigned int max_phys_sect; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/