Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932258AbbKLSsk (ORCPT ); Thu, 12 Nov 2015 13:48:40 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:34461 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754356AbbKLSsj (ORCPT ); Thu, 12 Nov 2015 13:48:39 -0500 MIME-Version: 1.0 In-Reply-To: <1447346238-29153-1-git-send-email-jmarchan@redhat.com> References: <1447341424-11466-1-git-send-email-jmarchan@redhat.com> <1447346238-29153-1-git-send-email-jmarchan@redhat.com> Date: Thu, 12 Nov 2015 21:48:38 +0300 Message-ID: Subject: Re: [PATCH V2] mm: vmalloc: don't remove inexistent guard hole in remove_vm_area() From: Andrey Ryabinin To: Jerome Marchand Cc: "linux-mm@kvack.org" , Andrew Morton , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 17 2015-11-12 19:37 GMT+03:00 Jerome Marchand : > Commit 71394fe50146 ("mm: vmalloc: add flag preventing guard hole > allocation") missed a spot. Currently remove_vm_area() decreases > vm->size to "remove" the guard hole page, even when it isn't present. > All but one users just free the vm_struct rigth away and never access > vm->size anyway. > Don't touch the size in remove_vm_area() and have __vunmap() use the > proper get_vm_area_size() helper. > > Signed-off-by: Jerome Marchand Acked-by: Andrey Ryabinin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/