Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753443AbbKLTJM (ORCPT ); Thu, 12 Nov 2015 14:09:12 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:48823 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbbKLTJL (ORCPT ); Thu, 12 Nov 2015 14:09:11 -0500 User-Agent: K-9 Mail for Android In-Reply-To: <5644E32F.6010104@free.fr> References: <1447350020-27969-1-git-send-email-mans@mansr.com> <5644E32F.6010104@free.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035 From: =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= Date: Thu, 12 Nov 2015 19:09:05 +0000 To: Mason CC: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2042 Lines: 55 On 12 November 2015 19:06:23 GMT+00:00, Mason wrote: >On 12/11/2015 18:40, Mans Rullgard wrote: >> Commit 77a993942 "phy/at8031: enable at8031 to work on interrupt >mode" >> added interrupt support for the 8031 PHY but left out the other two >> chips supported by this driver. >> >> This patch sets the .ack_interrupt and .config_intr functions for the >> 8030 and 8035 drivers as well. >> >> Signed-off-by: Mans Rullgard >> --- >> I have only tested this with an 8035. I can't find a datasheet for >> the 8030, but since 8031, 8032, and 8035 all have the same register >> layout, there's a good chance 8030 does as well. >> --- >> drivers/net/phy/at803x.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c >> index fabf11d..2d020a3 100644 >> --- a/drivers/net/phy/at803x.c >> +++ b/drivers/net/phy/at803x.c >> @@ -308,6 +308,8 @@ static struct phy_driver at803x_driver[] = { >> .flags = PHY_HAS_INTERRUPT, >> .config_aneg = genphy_config_aneg, >> .read_status = genphy_read_status, >> + .ack_interrupt = at803x_ack_interrupt, >> + .config_intr = at803x_config_intr, >> .driver = { >> .owner = THIS_MODULE, >> }, >> @@ -327,6 +329,8 @@ static struct phy_driver at803x_driver[] = { >> .flags = PHY_HAS_INTERRUPT, >> .config_aneg = genphy_config_aneg, >> .read_status = genphy_read_status, >> + .ack_interrupt = at803x_ack_interrupt, >> + .config_intr = at803x_config_intr, >> .driver = { >> .owner = THIS_MODULE, >> }, > >Shouldn't we take the opportunity to clean up the duplicated register >definitions? (I'll send an informal patch to spur discussion.) > >Regards. That can be done independently. Feel free to send a patch. -- Måns Rullgård -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/