Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754160AbbKLWOV (ORCPT ); Thu, 12 Nov 2015 17:14:21 -0500 Received: from smtp4-g21.free.fr ([212.27.42.4]:49566 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752940AbbKLWOT (ORCPT ); Thu, 12 Nov 2015 17:14:19 -0500 Subject: Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035 To: Florian Fainelli Cc: Mans Rullgard , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1447350020-27969-1-git-send-email-mans@mansr.com> <5644E32F.6010104@free.fr> <5644E530.7010101@gmail.com> From: Mason Message-ID: <56450F33.2000504@free.fr> Date: Thu, 12 Nov 2015 23:14:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0 SeaMonkey/2.38 MIME-Version: 1.0 In-Reply-To: <5644E530.7010101@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2396 Lines: 63 On 12/11/2015 20:14, Florian Fainelli wrote: > On 12/11/15 11:09, M?ns Rullg?rd wrote: >> On 12 November 2015 19:06:23 GMT+00:00, Mason wrote: >>> On 12/11/2015 18:40, Mans Rullgard wrote: >>>> Commit 77a993942 "phy/at8031: enable at8031 to work on interrupt mode" >>>> added interrupt support for the 8031 PHY but left out the other two >>>> chips supported by this driver. >>>> >>>> This patch sets the .ack_interrupt and .config_intr functions for the >>>> 8030 and 8035 drivers as well. >>>> >>>> Signed-off-by: Mans Rullgard >>>> --- >>>> I have only tested this with an 8035. I can't find a datasheet for >>>> the 8030, but since 8031, 8032, and 8035 all have the same register >>>> layout, there's a good chance 8030 does as well. >>>> --- >>>> drivers/net/phy/at803x.c | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c >>>> index fabf11d..2d020a3 100644 >>>> --- a/drivers/net/phy/at803x.c >>>> +++ b/drivers/net/phy/at803x.c >>>> @@ -308,6 +308,8 @@ static struct phy_driver at803x_driver[] = { >>>> .flags = PHY_HAS_INTERRUPT, >>>> .config_aneg = genphy_config_aneg, >>>> .read_status = genphy_read_status, >>>> + .ack_interrupt = at803x_ack_interrupt, >>>> + .config_intr = at803x_config_intr, >>>> .driver = { >>>> .owner = THIS_MODULE, >>>> }, >>>> @@ -327,6 +329,8 @@ static struct phy_driver at803x_driver[] = { >>>> .flags = PHY_HAS_INTERRUPT, >>>> .config_aneg = genphy_config_aneg, >>>> .read_status = genphy_read_status, >>>> + .ack_interrupt = at803x_ack_interrupt, >>>> + .config_intr = at803x_config_intr, >>>> .driver = { >>>> .owner = THIS_MODULE, >>>> }, >>> >>> Shouldn't we take the opportunity to clean up the duplicated register >>> definitions? (I'll send an informal patch to spur discussion.) >>> >>> Regards. >> >> That can be done independently. Feel free to send a patch. > > Agreed, that deserve a separate patch. Isn't there a problem when at803x_set_wol() sets the AT803X_WOL_ENABLE bit, but a DISABLE/ENABLE cycle through at803x_config_intr() will discard that bit? Regards. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/