Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754510AbbKMA1P (ORCPT ); Thu, 12 Nov 2015 19:27:15 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34519 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754019AbbKMA1N (ORCPT ); Thu, 12 Nov 2015 19:27:13 -0500 Message-ID: <56452E2A.9050501@gmail.com> Date: Thu, 12 Nov 2015 16:26:18 -0800 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: David Miller , jarod@redhat.com CC: linux-kernel@vger.kernel.org, edumazet@google.com, j.vosburgh@gmail.com, vfalico@gmail.com, gospo@cumulusnetworks.com, jiri@resnulli.us, razor@blackwall.org, mkubecek@suse.cz, alexander.duyck@gmail.com, netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot Subject: Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs References: <1446583017-19021-1-git-send-email-jarod@redhat.com> <1446610172-21420-1-git-send-email-jarod@redhat.com> <20151104.215632.964832400121049446.davem@davemloft.net> In-Reply-To: <20151104.215632.964832400121049446.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2306 Lines: 48 On 04/11/15 18:56, David Miller wrote: >> Fixes: fd867d51f889 ("net/core: generic support for disabling netdev features down stack") > ... >> Reported-by: Nikolay Aleksandrov >> Signed-off-by: Jarod Wilson >> --- >> v2: Based on suggestions from Alex, and with not changing err to ret, this >> patch actually becomes quite minimal and doesn't ugly up the code much. > > Applied, thanks. This causes some warnings to be displayed for DSA stacked devices: [ 1.272297] brcm-sf2 f0b00000.ethernet_switch: Starfighter 2 top: 4.00, core: 2.00 base: 0xf0c80000, IRQs: 68, 69 [ 1.283181] libphy: dsa slave smi: probed [ 1.344088] f0b403c0.mdio:05: Broadcom BCM7445 PHY revision: 0xd0, patch: 3 [ 1.658917] brcm-sf2 f0b00000.ethernet_switch gphy (uninitialized): attached PHY at address 5 [Broadcom BCM7445] [ 1.669414] brcm-sf2 f0b00000.ethernet_switch gphy: set_features() failed (-1); wanted 0x0000000000004020, left 0x0000000000004820 [ 1.734202] brcm-sf2 f0b00000.ethernet_switch rgmii_1 (uninitialized): attached PHY at address 0 [Generic PHY] [ 1.744486] brcm-sf2 f0b00000.ethernet_switch rgmii_1: set_features() failed (-1); wanted 0x0000000000004020, left 0x0000000000004820 [ 1.809091] brcm-sf2 f0b00000.ethernet_switch rgmii_2 (uninitialized): attached PHY at address 1 [Generic PHY] [ 1.819364] brcm-sf2 f0b00000.ethernet_switch rgmii_2: set_features() failed (-1); wanted 0x0000000000004020, left 0x0000000000004820 [ 1.884090] brcm-sf2 f0b00000.ethernet_switch moca (uninitialized): attached PHY at address 2 [Generic PHY] [ 1.894109] brcm-sf2 f0b00000.ethernet_switch moca: set_features() failed (-1); wanted 0x0000000000004020, left 0x0000000000004820 DSA slave network devices are not associated with their master network device using the typical lower/upper netdev helpers. I do not have a good fix to come up with yet, but if you see something obvious with net/dsa/slave.c, feel free to send patches for testing, I can boot net-next on this platform. -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/