Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753163AbbKMHU7 (ORCPT ); Fri, 13 Nov 2015 02:20:59 -0500 Received: from mailgw01.mediatek.com ([218.249.47.110]:34829 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750779AbbKMHU5 (ORCPT ); Fri, 13 Nov 2015 02:20:57 -0500 X-Listener-Flag: 11101 Message-ID: <1447399245.9118.14.camel@mhfsdcap03> Subject: Re: [PATCH v6 1/3] doc: dt: add documentation for Mediatek spi-nor controller From: bayi cheng To: Brian Norris CC: David Woodhouse , Rob Herring , Pawel Moll , Mark Rutland , "Ian Campbell" , Kumar Gala , Matthias Brugger , "Daniel Kurtz" , Sascha Hauer , , , , , , , , Date: Fri, 13 Nov 2015 15:20:45 +0800 In-Reply-To: <20151111203823.GJ12143@google.com> References: <1446824889-16144-1-git-send-email-bayi.cheng@mediatek.com> <1446824889-16144-2-git-send-email-bayi.cheng@mediatek.com> <20151111203823.GJ12143@google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4693 Lines: 115 On Wed, 2015-11-11 at 12:38 -0800, Brian Norris wrote: > On Fri, Nov 06, 2015 at 11:48:07PM +0800, Bayi Cheng wrote: > > Add device tree binding documentation for serial flash with > > Mediatek serial flash controller > > > > Signed-off-by: Bayi Cheng > > --- > > Applied to l2-mtd.git/next (for 4.5). This will show up in > linux-next.git after the merge window. > > Also squashed in a small diff (below), to fix up some language issues > and to refer the reader to the jedec,spi-nor.txt document. > OK, I will fix it in next patch! > > .../devicetree/bindings/mtd/mtk-quadspi.txt | 41 ++++++++++++++++++++++ > > 1 file changed, 41 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mtd/mtk-quadspi.txt > > > > diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt > > new file mode 100644 > > index 0000000..866b492 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt > > @@ -0,0 +1,41 @@ > > +* MTD SPI nor driver for MTK MT81xx (and similar) serial flash controller > > The DT binding document shouldn't be talking about software (i.e., > shouldn't be talking about "drivers"). > OK, I will fix it. > > + > > +Required properties: > > +- compatible: should be "mediatek,mt8173-nor"; > > +- reg: physical base address and length of the controller's register > > +- clocks: the phandle of the clock needed by the nor controller > > +- clock-names: the name of the clocks > > + the clocks needed "spi" and "sf". "spi" is used for spi bus, > > + and "sf" is used for controller, these are the clocks witch > > + hardware needs to enabling nor flash and nor flash controller. > > + See Documentation/devicetree/bindings/clock/clock-bindings.txt for details. > > +- #address-cells: should be <1> > > +- #size-cells: should be <0> > > + > > +The SPI Flash must be a child of the nor_flash node and must have a > > +compatible property. > > + > > +Required properties: > > +- compatible: May include a device-specific string consisting of the manufacturer > > + and name of the chip. Must also include "jedec,spi-nor" for any > > + SPI NOR flash that can be identified by the JEDEC READ ID opcode (0x9F). > > +- reg : Chip-Select number > > + > > +Example: > > + > > +nor_flash: spi@1100d000 { > > + compatible = "mediatek,mt8173-nor"; > > + reg = <0 0x1100d000 0 0xe0>; > > + clocks = <&pericfg CLK_PERI_SPI>, > > + <&topckgen CLK_TOP_SPINFI_IFR_SEL>; > > + clock-names = "spi", "sf"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + > > + flash@0 { > > + compatible = "jedec,spi-nor"; > > + reg = <0>; > > + }; > > +}; > > + > > diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt > index 866b492c38d2..fb314f09861b 100644 > --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt > +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt > @@ -1,19 +1,19 @@ > -* MTD SPI nor driver for MTK MT81xx (and similar) serial flash controller > +* Serial NOR flash controller for MTK MT81xx (and similar) > > Required properties: > - compatible: should be "mediatek,mt8173-nor"; > - reg: physical base address and length of the controller's register > -- clocks: the phandle of the clock needed by the nor controller > -- clock-names: the name of the clocks > - the clocks needed "spi" and "sf". "spi" is used for spi bus, > +- clocks: the phandle of the clocks needed by the nor controller > +- clock-names: the names of the clocks > + the clocks should be named "spi" and "sf". "spi" is used for spi bus, > and "sf" is used for controller, these are the clocks witch > hardware needs to enabling nor flash and nor flash controller. > See Documentation/devicetree/bindings/clock/clock-bindings.txt for details. > - #address-cells: should be <1> > - #size-cells: should be <0> > > -The SPI Flash must be a child of the nor_flash node and must have a > -compatible property. > +The SPI flash must be a child of the nor_flash node and must have a > +compatible property. Also see jedec,spi-nor.txt. > > Required properties: > - compatible: May include a device-specific string consisting of the manufacturer Thanks for your instruction! and I will fix it in the next patch! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/