Subject: Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for
 MIDIStreaming interface
To: Felipe Ferreri Tonello <eu@felipetonello.com>,
        Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        linux-usb@vger.kernel.org
References: <1447177929-22252-1-git-send-email-eu@felipetonello.com>
 <1447177929-22252-7-git-send-email-eu@felipetonello.com>
 <56423AB6.5090808@cogentembedded.com> <56430C99.2080703@felipetonello.com>
Cc: linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Robert Baldyga <r.baldyga@samsung.com>
From: Clemens Ladisch <clemens@ladisch.de>
Message-ID: <56459B3A.4010401@ladisch.de>
Date: Fri, 13 Nov 2015 09:11:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <56430C99.2080703@felipetonello.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1030
Lines: 33

Felipe Ferreri Tonello wrote:
> On 10/11/15 18:43, Sergei Shtylyov wrote:
>> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:
>>> @@ -75,6 +75,7 @@ struct f_midi {
>>>       struct usb_ep        *in_ep, *out_ep;
>>>       struct snd_card        *card;
>>>       struct snd_rawmidi    *rmidi;
>>> +    u8                    ms_id;
>>
>>   Why 'ms_id' is not aligned with the above field names?
>
> It is actually aligned.

It's not in the original mail, which contains tab characters.

> Here is from my local git diff:
>
> @@ -75,6 +75,7 @@ struct f_midi {
>     struct usb_ep       *in_ep, *out_ep;
>     struct snd_card     *card;
>     struct snd_rawmidi  *rmidi;
> +   u8                  ms_id;

Apparently, you're using four spaces per tab.  Linux uses eight.


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/