Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754334AbbKMIeB (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 Nov 2015 03:34:01 -0500
Received: from mail-wm0-f45.google.com ([74.125.82.45]:33489 "EHLO
	mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753441AbbKMIeA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 Nov 2015 03:34:00 -0500
Date: Fri, 13 Nov 2015 10:33:57 +0200
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Naoya Horiguchi <nao.horiguchi@gmail.com>
Subject: Re: [PATCH v1] mm: fix mapcount mismatch in hugepage migration
Message-ID: <20151113083357.GA28904@node.shutemov.name>
References: <1447375469-9298-1-git-send-email-n-horiguchi@ah.jp.nec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1447375469-9298-1-git-send-email-n-horiguchi@ah.jp.nec.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2664
Lines: 52

On Fri, Nov 13, 2015 at 09:44:29AM +0900, Naoya Horiguchi wrote:
> try_to_unmap_one() should be able to handle hugetlb, but page_remove_rmap()
> in that function takes false as a compound flag, which breaks hugepage migration
> with the following message.
> 
>   Soft offlining page 0x1d4a00 at 0x7ff634a00000
>   soft offline: 0x1d4a00: migration failed 1, type 60000000000401c
>   BUG: Bad page state in process sysctl  pfn:1d4a00
>   page:ffffea0007528000 count:0 mapcount:0 mapping:          (null) index:0x0 compound_mapcount: 10
>   flags: 0x600000000004008(uptodate|head)
>   page dumped because: nonzero mapcount
>   Modules linked in: cfg80211 rfkill crc32c_intel virtio_balloon serio_raw i2c_piix4 virtio_blk virtio_net ata_generic pata_acpi
>   CPU: 3 PID: 11882 Comm: sysctl Tainted: G        W       4.3.0-mmotm-2015-11-10-15-53-151112-1812-00015-53+ #240
>   Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
>    ffffffff81a1a124 ffff8800da047bd0 ffffffff81340adf ffffea0007528000
>    ffff8800da047bf8 ffffffff8116e206 0000000000000009 ffffffff81f72538
>    ffffea0007528000 ffff8800da047c48 ffffffff8116e6d6 0000020000000000
>   Call Trace:
>    [<ffffffff81340adf>] dump_stack+0x44/0x55
>    [<ffffffff8116e206>] bad_page+0xc6/0x110
>    [<ffffffff8116e6d6>] free_pages_prepare+0x486/0x500
>    [<ffffffff81170f9a>] __free_pages_ok+0x1a/0xb0
>    [<ffffffff81171af1>] __free_pages+0x21/0x40
>    [<ffffffff811b5d79>] update_and_free_page+0xa9/0x230
>    [<ffffffff811b6641>] free_pool_huge_page+0xc1/0xe0
>    [<ffffffff811b6d02>] set_max_huge_pages+0x382/0x4d0
>    [<ffffffff811b7002>] hugetlb_sysctl_handler_common+0xa2/0xd0
>    [<ffffffff811b823e>] hugetlb_sysctl_handler+0x1e/0x20
>    [<ffffffff812535fe>] proc_sys_call_handler+0xae/0xc0
>    [<ffffffff81253624>] proc_sys_write+0x14/0x20
>    [<ffffffff811e8758>] __vfs_write+0x28/0xe0
>    [<ffffffff810d1864>] ? percpu_down_read+0x14/0x60
>    [<ffffffff811e8d29>] vfs_write+0xa9/0x190
>    [<ffffffff811e9646>] SyS_write+0x46/0xb0
>    [<ffffffff8163d797>] entry_SYSCALL_64_fastpath+0x12/0x6a
> 
> This patch simply fixes this by giving the compound flag via PageHuge.
> ---
> # This patch is against mmotm-2015-11-10-15-53 as a fix for "rmap: add argument
> # to charge compound page".
> 
> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/