Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933374AbbKMKP5 (ORCPT ); Fri, 13 Nov 2015 05:15:57 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:49121 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933286AbbKMKN2 (ORCPT ); Fri, 13 Nov 2015 05:13:28 -0500 From: Luis Henriques To: linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com Cc: =?UTF-8?q?Salva=20Peir=C3=B3?= , Greg Kroah-Hartman , =?UTF-8?q?Moritz=20M=C3=BChlenhoff?= , Luis Henriques Subject: [PATCH 3.16.y-ckt 90/94] staging/dgnc: fix info leak in ioctl Date: Fri, 13 Nov 2015 10:10:24 +0000 Message-Id: <1447409428-12178-91-git-send-email-luis.henriques@canonical.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1447409428-12178-1-git-send-email-luis.henriques@canonical.com> References: <1447409428-12178-1-git-send-email-luis.henriques@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Extended-Stable: 3.16 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 37 3.16.7-ckt20 -stable review patch. If anyone has any objections, please let me know. ------------------ From: =?UTF-8?q?Salva=20Peir=C3=B3?= commit 4b6184336ebb5c8dc1eae7f7ab46ee608a748b05 upstream. The dgnc_mgmt_ioctl() code fails to initialize the 16 _reserved bytes of struct digi_dinfo after the ->dinfo_nboards member. Add an explicit memset(0) before filling the structure to avoid the info leak. Signed-off-by: Salva Peiró Signed-off-by: Greg Kroah-Hartman Cc: Moritz Mühlenhoff Signed-off-by: Luis Henriques --- drivers/staging/dgnc/dgnc_mgmt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c index c5b425bf6692..eaba5d73362a 100644 --- a/drivers/staging/dgnc/dgnc_mgmt.c +++ b/drivers/staging/dgnc/dgnc_mgmt.c @@ -143,6 +143,7 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) DGNC_LOCK(dgnc_global_lock, lock_flags); + memset(&ddi, 0, sizeof(ddi)); ddi.dinfo_nboards = dgnc_NumBoards; sprintf(ddi.dinfo_version, "%s", DG_PART); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/