Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754714AbbKMMsL (ORCPT ); Fri, 13 Nov 2015 07:48:11 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:32887 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754666AbbKMMsJ (ORCPT ); Fri, 13 Nov 2015 07:48:09 -0500 Date: Fri, 13 Nov 2015 18:17:57 +0530 From: Sudip Mukherjee To: Nizam Haider Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org, Nizam Haider , driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] Staging: dgnc: dgnc_neo.c: checkpatch cleanup Message-ID: <20151113124757.GA18741@sudip-pc> References: <1447413491-17055-1-git-send-email-nizamhaider786@gmail.com> <1447413491-17055-2-git-send-email-nizamhaider786@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447413491-17055-2-git-send-email-nizamhaider786@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1136 Lines: 25 On Fri, Nov 13, 2015 at 04:48:11PM +0530, Nizam Haider wrote: > This patch fixes several warning during checkpatch > > 355: CHECK: Logical continuations should be on the previous line > 1111: CHECK: braces {} should be used on all arms of this statement > 1631: CHECK: spaces preferred around that '|' (ctx:VxV) > 1782: CHECK: spaces preferred around that '*' (ctx:VxV) > 1783: CHECK: spaces preferred around that '*' (ctx:VxV) > 1783: CHECK: spaces preferred around that '+' (ctx:VxV) > 1787: CHECK: Logical continuations should be on the previous line > 1788: CHECK: Logical continuations should be on the previous line These are three different types of changes. Please split them in three different patches. CHECK: Logical continuations should be on the previous line CHECK: braces {} should be used on all arms of this statement CHECK: spaces preferred around that ' ' regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/