Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754214AbbKMNGY (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 Nov 2015 08:06:24 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:33677 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752126AbbKMNGX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 Nov 2015 08:06:23 -0500
MIME-Version: 1.0
In-Reply-To: <20151113130331.GB18741@sudip-pc>
References: <1447237306-46901-1-git-send-email-shivanib134@gmail.com>
	<201511111859.mIw4mICa%fengguang.wu@intel.com>
	<CAKHNQQHLwsfv6OKOci4g4405_vcFgy7GNcUAWX0aDAS+GFU6gw@mail.gmail.com>
	<20151111173100.GA20846@kroah.com>
	<CAKHNQQEW9ZcYrdowy5cFkJXqzEyoy+CseJg_3ge0QCC7=5oA3A@mail.gmail.com>
	<20151113130331.GB18741@sudip-pc>
Date: Fri, 13 Nov 2015 18:36:22 +0530
Message-ID: <CAKHNQQHdTHff9J+dQkAZMhTTFHcoZ1QV-moDx4AdXSdO0CWe_A@mail.gmail.com>
Subject: Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
From: Shivani Bhardwaj <shivanib134@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, devel@driverdev.osuosl.org,
        "Dilger, Andreas" <andreas.dilger@intel.com>,
        linux-kernel@vger.kernel.org, "Drokin, Oleg" <oleg.drokin@intel.com>,
        kbuild-all@01.org, lustre-devel@lists.lustre.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1488
Lines: 44

On Fri, Nov 13, 2015 at 6:33 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
>
> On Wed, Nov 11, 2015 at 11:03:34PM +0530, Shivani Bhardwaj wrote:
> > On Wed, Nov 11, 2015 at 11:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > > On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
> > >> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
> <snip>
> > >>
> > >> I'm not getting any of these errors at compilation. I've checked
> > >> thrice. Could you please tell what am I doing wrong so that I can
> > >> avoid introducing errors in future patches?
> > >
> > > Use the .config provided, odds are you have lockdep enabled.
> >
> > Thanks Greg.
> > I tried that. Still no errors. Any other suggestion?
>
> while removing the wrapper you missed that cl_lock_lockdep_init() is:
>
> static void cl_lock_lockdep_init(struct cl_lock *lock)
> {
>                 lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> }
>
> if CONFIG_LOCKDEP is defined.
> and if CONFIG_LOCKDEP is not defined then:
>
> static void cl_lock_lockdep_init(struct cl_lock *lock)
> {}
>
> your patch is using lockdep_set_class_and_name() in both cases.
>

Yes! This is the problem.
Thank you Sudip.

> regards
> sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/