Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932246AbbKMNd4 (ORCPT ); Fri, 13 Nov 2015 08:33:56 -0500 Received: from mail1.bemta12.messagelabs.com ([216.82.251.3]:12990 "EHLO mail1.bemta12.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754355AbbKMNdz (ORCPT ); Fri, 13 Nov 2015 08:33:55 -0500 X-Env-Sender: Marc_Gonzalez@sigmadesigns.com X-Msg-Ref: server-16.tower-219.messagelabs.com!1447421615!9014150!1 X-Originating-IP: [195.215.56.170] X-StarScan-Received: X-StarScan-Version: 7.19.2; banners=-,-,- X-VirusChecked: Checked Subject: Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by clocksource_mmio_init To: Daniel Lezcano CC: Thomas Gleixner , LKML References: <1447412292-841-1-git-send-email-daniel.lezcano@linaro.org> From: Marc Gonzalez Message-ID: <5645E6AE.4040402@sigmadesigns.com> Date: Fri, 13 Nov 2015 14:33:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0 SeaMonkey/2.38 MIME-Version: 1.0 In-Reply-To: <1447412292-841-1-git-send-email-daniel.lezcano@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.27.0.114] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1169 Lines: 39 On 13/11/2015 11:58, Daniel Lezcano wrote: > The current code to initialize, register and read the clocksource is > already factored out in mmio.c via the clocksource_mmio_init function. > > Factor out the code with the clocksource_mmio_init function. > > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/tango_xtal.c | 18 +++--------------- > 1 file changed, 3 insertions(+), 15 deletions(-) Hello Daniel, I think you also need: diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 63c878d4d9e3..92bf3fc3e646 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -278,6 +278,7 @@ config CLKSRC_MIPS_GIC config CLKSRC_TANGO_XTAL bool select CLKSRC_OF + select CLKSRC_MMIO config CLKSRC_PXA def_bool y if ARCH_PXA || ARCH_SA1100 Otherwise, we'll get "undefined reference" link errors. Regards. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/